Custom sentence parser mechanism #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkurki
force-pushed
the
custom-sentence-parser-mechanism
branch
3 times, most recently
from
ace4684
to
01bfecc
Compare
tkurki
changed the title
There is no need to require that individual sentence parsers set source in their output. This change allows source to not be there. This makes adding custom sentence parsers a little more robust, as the exception from a missing source was silently ignored.
tkurki
force-pushed
the
custom-sentence-parser-mechanism
branch
from
01bfecc
to
fe84501
Compare
sbender9
reviewed
Mar 30, 2021
tkurki
force-pushed
the
custom-sentence-parser-mechanism
branch
from
fe84501
to
8d76b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism how a SK Server plugin can publish new sentence parsers, that the server passes to the NMEA0183 parser. See the included example of such a plugin for details.
todo: