Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use navigation.courseRhumbline.nextPoint.position in RMB #252

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Use navigation.courseRhumbline.nextPoint.position in RMB #252

merged 2 commits into from
Feb 17, 2024

Conversation

Techstyleuk
Copy link
Contributor

@Techstyleuk Techstyleuk commented Feb 16, 2024 •
edited by tkurki
Loading

The RMB parser stored the next waypoint position to navigation.courseRhumbline.nextPoint

This is incorrect, and is changed to navigation.courseRhumbline.nextPoint.position

Fixes #240.

@Techstyleuk
Update RMB.js - Address issue SignalK#240
e08fb4e 
The RMB parser stored the next waypoint position to navigation.courseRhumbline.nextPoint

This is incorrect, and is changed to navigation.courseRhumbline.nextPoint.position
@Techstyleuk Techstyleuk mentioned this pull request Feb 16, 2024
Closed
@tkurki tkurki added the fix label Feb 16, 2024
@tkurki
Copy link
Member

tkurki commented Feb 16, 2024

I took the liberty to add Fixes #240 to your PR description, that way Github automatically links the PR to the issue and closes the issue when the PR is merged.

Please update the test that asserts the result also.

@tkurki
Copy link
Member

tkurki commented Feb 16, 2024

npm test in your local environment to run tests locally.

@tkurki tkurki merged commit 141bcbe into SignalK:master Feb 17, 2024
3 checks passed
@tkurki tkurki changed the title Update RMB.js - Address issue #240 Use navigation.courseRhumbline.nextPoint.position in RMB Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RMB parser stores next waypoint position to incorrect SignalK field
2 participants
@Techstyleuk @tkurki