Fix: Course API - check loaded state href values more rigorously #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkurki
reviewed
Feb 5, 2025
tkurki
reviewed
Feb 7, 2025
Use isValidWaypointCourse and isValidRouteCourse so that the actual validation is simple: test for either and if none match return default.
Make references to the value representing 'no course is set' situation explicit.
tkurki
force-pushed
the
validate-stored-course-info
branch
from
553bd17 to
df3eba9
Compare
tkurki
force-pushed
the
validate-stored-course-info
branch
from
df3eba9 to
43d6530
Compare
|
Have tested. Looks good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1873
Perform check on resource references (
href) when loading stored state to ensure the resources still exist.