feat(platform) : scheduling agent runner #8634

Abhi1992002 · 2024-11-13T12:05:10Z

Feature #8461

Created a table on the monitor page to display all schedules.
This table includes options to filter schedules based on graphs and to create a new schedule.
Each graph page now has a button to create a schedule.

Changes 🏗️

Removed isEnabled from autogpt_platform/backend/backend/data/schedule.py because it was not fetching the disabled schedules, which prevented them from ending as cron jobs.
Added a schedule table on the monitor page to display all schedules:
- Allows filtering of schedules by agent name.
- Option to create a new schedule.
Used cronExpressionManager.ts to create cron expressions and descriptions for each cron expression.
Created types and requests for schedule endpoints.
Reused the run button component to enable rescheduling of graphs.

Some Screenshots

Video

Untitled.video.-.Made.with.Clipchamp.mp4

github-actions · 2024-11-13T12:05:26Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

qodo-merge-pro · 2024-11-13T12:05:39Z

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Possible Bug Removing isEnabled filter from get_active_schedules() query could return unwanted disabled schedules. Verify this change doesn't cause issues with cron job management. Incomplete Error Handling The schedule creation and toggle functionality lacks proper error handling and user feedback for failure cases. This could lead to a confusing user experience if API calls fail. Input Validation The cron expression generation lacks comprehensive input validation, which could allow invalid cron expressions to be created. Need to validate all input parameters.

netlify · 2024-11-13T12:05:49Z

✅ Deploy Preview for auto-gpt-docs canceled.

Name	Link
🔨 Latest commit	`efcd558`
🔍 Latest deploy log	https://app.netlify.com/sites/auto-gpt-docs/deploys/6735dcdbad23f200088bca06

github-actions · 2024-11-13T12:09:50Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

Torantulino · 2024-11-13T17:37:35Z

Amazing contribution @Abhi1992002, well done!
The would pair very well with #8501

majdyz

Thank you for the contributions! I've added a couple of comments related to the API, let me know your thoughts!

majdyz · 2024-11-14T10:10:55Z

autogpt_platform/frontend/src/app/page.tsx


  const api = useMemo(() => new AutoGPTServerAPI(), []);

+  const fetchSchedules = useCallback(async () => {
+    const schedulesData: Schedule[] = [];
+    for (const flow of flows) {


I see that you did this due to non-optimized backend, I've improved the API here so you can do GET /schedules and get all the schedules for a user without firing multiple requests and add more information on the GET response:
#8649

I'm happy with any of the ordering, we can first get this merged and improve it and update the routing on my PR, or you can rebase your PR based on the above PR.

majdyz · 2024-11-14T10:14:45Z

autogpt_platform/frontend/src/lib/monitor/cronExpressionManager.ts

@@ -0,0 +1,239 @@
+export class CronExpressionManager {


Would this be any simpler if we utilize https://www.npmjs.com/package/cron ?

majdyz · 2024-11-14T10:15:33Z

autogpt_platform/frontend/src/components/cronScheduler.tsx

+} from "@/components/ui/dialog";
+import { Separator } from "./ui/separator";
+import { CronExpressionManager } from "@/lib/monitor/cronExpressionManager";
+// import { RadioGroup, RadioGroupItem } from "@/components/ui/radio-group";


nit: Remove this?

majdyz · 2024-11-14T10:19:22Z

autogpt_platform/frontend/src/components/cronScheduler.tsx

+          <Separator />
+          {/*
+
+            On the backend, we are using standard cron expressions,


This is a really good idea, I can accommodate this on my API #8649, what field do you think you need for this? I can add end_time on the GET PUT & POST request wdyt?

majdyz · 2024-11-14T10:19:42Z

autogpt_platform/frontend/src/hooks/useAgentGraph.ts

+            title: "Agent scheduling successful",
+          });
+
+          // if schduling is done from the monitor page, then redirect to monitor page after successful scheduling


majdyz · 2024-11-14T10:21:16Z

autogpt_platform/frontend/src/lib/autogpt-server-api/baseClient.ts

+    return this._request("PUT", `/graphs/schedules/${scheduleId}`, update);
+  }
+
+  async getSchedules(graphId: string): Promise<{ [key: string]: string }> {


After seeing it used by the client, I think it makes much more sense to make the API route simply /schedules without the graph intervention, I can add graph_id as a query parameter for GET request as an optional filtering clause.

majdyz · 2024-11-14T10:21:39Z

autogpt_platform/frontend/src/lib/autogpt-server-api/types.ts

@@ -329,3 +329,19 @@ export type AnalyticsDetails = {
  data: { [key: string]: any };
  index: string;
 };
+
+// Schedule types


nit: the comment, except the cron expression, might not be necessary

Swiftyos · 2024-11-14T10:32:57Z

Just tested it, this is a fantastic contribution @Abhi1992002 Thank you!

Abhi1992002 added 4 commits November 12, 2024 08:54

add: ui for scheduling agent

0f1e149

adding requests and type for schedule endpoints

014fcf4

feat : monitor schdules on monitor page

e9892e7

add: Complete monitor page

e32f8a8

Abhi1992002 requested a review from a team as a code owner November 13, 2024 12:05

Abhi1992002 requested review from Bentlybro and kcze and removed request for a team November 13, 2024 12:05

github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end conflicts Automatically applied to PRs with merge conflicts labels Nov 13, 2024

github-actions bot added the size/xl label Nov 13, 2024

qodo-merge-pro bot added the Review effort [1-5]: 4 label Nov 13, 2024

Merge branch 'dev' into feature/scheduling-agent-runner

2ce5732

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 13, 2024

fix filter on monitor page

183cc22

Abhi1992002 changed the title ~~Feature/scheduling agent runner~~ feat(platform) : scheduling agent runner Nov 13, 2024

fix linting

7c2b59b

Torantulino and others added 3 commits November 13, 2024 17:37

Merge branch 'dev' into feature/scheduling-agent-runner

5beb1c5

Merge branch 'dev' into feature/scheduling-agent-runner

5c537d0

Merge branch 'dev' into feature/scheduling-agent-runner

28804dc

majdyz mentioned this pull request Nov 14, 2024

fix(backend): Add execution persistence for execution scheduler service #8649

Merged

12 tasks

Torantulino enabled auto-merge (squash) November 14, 2024 09:36

Merge branch 'dev' into feature/scheduling-agent-runner

29c409c

majdyz reviewed Nov 14, 2024

View reviewed changes

Merge branch 'dev' into feature/scheduling-agent-runner

2fa7e24

majdyz disabled auto-merge November 14, 2024 10:26

Swiftyos added 2 commits November 14, 2024 12:16

PR nits

88d8130

Added Docker Compose env var

efcd558

Swiftyos merged commit dd0081a into Significant-Gravitas:dev Nov 14, 2024
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(platform) : scheduling agent runner #8634

feat(platform) : scheduling agent runner #8634

Abhi1992002 commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024

qodo-merge-pro bot commented Nov 13, 2024

netlify bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024

Torantulino commented Nov 13, 2024

majdyz left a comment

majdyz Nov 14, 2024

majdyz Nov 14, 2024

majdyz Nov 14, 2024

majdyz Nov 14, 2024

majdyz Nov 14, 2024

majdyz Nov 14, 2024

majdyz Nov 14, 2024 •

edited

Loading

Swiftyos commented Nov 14, 2024

feat(platform) : scheduling agent runner #8634

feat(platform) : scheduling agent runner #8634

Conversation

Abhi1992002 commented Nov 13, 2024 • edited Loading

Changes 🏗️

Some Screenshots

Video

github-actions bot commented Nov 13, 2024

qodo-merge-pro bot commented Nov 13, 2024

PR Reviewer Guide 🔍

netlify bot commented Nov 13, 2024 • edited Loading

✅ Deploy Preview for auto-gpt-docs canceled.

github-actions bot commented Nov 13, 2024

Torantulino commented Nov 13, 2024

majdyz left a comment

Choose a reason for hiding this comment

majdyz Nov 14, 2024

Choose a reason for hiding this comment

majdyz Nov 14, 2024

Choose a reason for hiding this comment

majdyz Nov 14, 2024

Choose a reason for hiding this comment

majdyz Nov 14, 2024

Choose a reason for hiding this comment

majdyz Nov 14, 2024

Choose a reason for hiding this comment

majdyz Nov 14, 2024

Choose a reason for hiding this comment

majdyz Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

Swiftyos commented Nov 14, 2024

Abhi1992002 commented Nov 13, 2024 •

edited

Loading

netlify bot commented Nov 13, 2024 •

edited

Loading

majdyz Nov 14, 2024 •

edited

Loading