Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dx(backend): Fix pre-commit isort step #8726

Merged
merged 1 commit into from
Nov 20, 2024
Merged

dx(backend): Fix pre-commit isort step #8726

merged 1 commit into from
Nov 20, 2024
+7 −4

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Nov 20, 2024 •
edited
Loading

Extracted from #8358 because of #8358 (comment)

isort doesn't detect first-party packages correctly and applies its own styling which is incompatible with black.

Changes 🏗️

  • Set tool.isort.profile = "black"
  • Explicitly pass the first-party package name in the isort jobs in the pre-commit config

@Pwuts Pwuts requested a review from a team as a code owner November 20, 2024 01:06
@Pwuts Pwuts requested review from Bentlybro and kcze and removed request for a team November 20, 2024 01:06
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/m labels Nov 20, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 57f9624
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/673d3635e1d4550008af0abf

@Pwuts Pwuts mentioned this pull request Nov 20, 2024
Merged
14 tasks
@Pwuts Pwuts enabled auto-merge (squash) November 20, 2024 01:08
@Pwuts Pwuts requested a review from ntindle November 20, 2024 01:08
@Pwuts Pwuts merged commit 33dd2eb into dev Nov 20, 2024
14 checks passed
@Pwuts Pwuts deleted the reinier/fix-pre-commit-isort branch November 20, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntindle ntindle ntindle approved these changes

@Bentlybro Bentlybro Awaiting requested review from Bentlybro Bentlybro is a code owner automatically assigned from Significant-Gravitas/maintainers

@kcze kcze Awaiting requested review from kcze kcze is a code owner automatically assigned from Significant-Gravitas/maintainers

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pwuts @ntindle