refactor(backend): Apply lint on autogpt_lib folder on backend/linter.py #8751

majdyz · 2024-11-25T10:40:58Z

linter.py, only applies in the backend module, not autogpt_libs.

The scope of this PR is to clear this out.

Changes 🏗️

Add a linting scope to both the backend & autogpt_libs modules, and apply the linter.

Checklist 📋

For code changes:

I have clearly listed my changes in the PR description
I have made a test plan
I have tested my changes according to the test plan:
- ...

Example test plan

Create from scratch and execute an agent with at least 3 blocks
Import an agent from file upload, and confirm it executes correctly
Upload agent to marketplace
Import an agent from marketplace and confirm it executes correctly
Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

.env.example is updated or already compatible with my changes
docker-compose.yml is updated or already compatible with my changes
I have included a list of my configuration changes in the PR description (under Changes)

Examples of configuration changes

Changing ports
Adding new services that need to communicate with each other
Secrets or environment variable changes
New or infrastructure changes such as databases

… on rest.py

qodo-merge-pro · 2024-11-25T10:41:39Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Code Smell The `settings` variable is redefined multiple times across different files. Consider refactoring to avoid redundancy and potential inconsistencies. Code Smell The import statements for `Config` and `Secrets` from `autogpt_libs.utils.settings` are repeated in multiple files. Consider centralizing these imports to improve maintainability. Possible Bug The `docs_url` assignment logic might not work as intended if `settings.config.app_env` is not `local`. Ensure that the URL is correctly set for other environments.

netlify · 2024-11-25T10:42:01Z

✅ Deploy Preview for auto-gpt-docs canceled.

Name	Link
🔨 Latest commit	`0fa679b`
🔍 Latest deploy log	https://app.netlify.com/sites/auto-gpt-docs/deploys/674d16a892020600088ba301

autogpt_platform/autogpt_libs/autogpt_libs/supabase_integration_credentials_store/store.py

github-actions · 2024-11-25T17:44:58Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

autogpt_platform/backend/backend/integrations/creds_manager.py

autogpt_platform/backend/backend/rest.py

autogpt_platform/docker-compose.platform.yml

github-actions · 2024-11-26T04:12:41Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

ntindle · 2024-11-26T04:51:05Z

why do we have the lib? market is moving into the backend in #8306 right? why not just delete the whole thing and put it in backend

majdyz · 2024-11-26T05:12:30Z

why do we have the lib? market is moving into the backend in #8306 right? why not just delete the whole thing and put it in backend

I think this is a separate useful discussion, Currently, it's very easy to introduce something that will be used in multiple services running in different nodes without even noticing. The aim for this PR is to reduce as much as possible the usage of backend code in IntegrationCredentialManagerStore code in lib, which was introduced as a hack.

@ntindle @Pwuts I think you can decide whether the libs still provide value or not.

aarushik93 · 2024-11-26T15:12:49Z

Imo, until market actually is merged as one we should keep autogpt_libs and if we want to delete it do it in a different PR afterwards

…ve-a-db-manager-process

majdyz · 2024-11-27T08:25:02Z

Agree... Can I get review on this? :)))

netlify · 2024-11-27T08:25:05Z

✅ Deploy Preview for auto-gpt-docs-dev canceled.

Name	Link
🔨 Latest commit	`0fa679b`
🔍 Latest deploy log	https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/674d16a9c393d20008a5e87b

autogpt_platform/autogpt_libs/autogpt_libs/supabase_integration_credentials_store/store.py

autogpt_platform/backend/linter.py

Co-authored-by: Reinier van der Leer <pwuts@agpt.co>

ntindle · 2024-11-29T07:39:29Z

Can we pretty please wait to do this until after #8648 if it turns into a ton of edited files

…ve-a-db-manager-process

Pwuts

LGTM! :)

- Resolves #8859 - Follow-up to #8751 ### Changes - Add `autogpt_libs` to the backend CI path filter - Add `ruff format` step for `autogpt_libs` to `linter.py` and `pre-commit` config - Run `poetry run format` with the new setup

feat(backend): Move Settings to AutoGPTLib & Spin-up Database manager…

9afb4d7

… on rest.py

majdyz requested review from ntindle and aarushik93 November 25, 2024 10:40

majdyz requested a review from a team as a code owner November 25, 2024 10:40

github-actions bot added platform/backend AutoGPT Platform - Back end platform/blocks size/l labels Nov 25, 2024

qodo-merge-pro bot added the Review effort [1-5]: 4 label Nov 25, 2024

majdyz commented Nov 25, 2024

View reviewed changes

autogpt_platform/autogpt_libs/autogpt_libs/supabase_integration_credentials_store/store.py Outdated Show resolved Hide resolved

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 25, 2024

majdyz commented Nov 26, 2024

View reviewed changes

autogpt_platform/backend/backend/integrations/creds_manager.py Outdated Show resolved Hide resolved

autogpt_platform/backend/backend/rest.py Outdated Show resolved Hide resolved

autogpt_platform/docker-compose.platform.yml Outdated Show resolved Hide resolved

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 26, 2024

majdyz enabled auto-merge (squash) November 26, 2024 04:13

Resolve conflicts

4ace1aa

majdyz force-pushed the zamilmajdy/open-1980-update-rest-server-to-have-a-db-manager-process branch from 966dcba to 4ace1aa Compare November 26, 2024 04:31

Fix docs

a54461e

github-actions bot added the documentation Improvements or additions to documentation label Nov 26, 2024

Merge branch 'dev' into zamilmajdy/open-1980-update-rest-server-to-ha…

c394227

…ve-a-db-manager-process

Pwuts changed the title ~~feat(backend): Move Settings to AutoGPTLib & Spin-up Database manager on rest.py~~ refactor(backend): Move Settings to AutoGPTLib & Spin-up Database manager on rest.py Nov 27, 2024

Pwuts previously requested changes Nov 27, 2024

View reviewed changes

autogpt_platform/autogpt_libs/autogpt_libs/supabase_integration_credentials_store/store.py Outdated Show resolved Hide resolved

autogpt_platform/backend/linter.py Outdated Show resolved Hide resolved

Revert settings.py

cf47c75

github-actions bot added size/s and removed size/m labels Nov 27, 2024

Update autogpt_platform/backend/linter.py

fed8d50

Co-authored-by: Reinier van der Leer <pwuts@agpt.co>

Merge branch 'dev' into zamilmajdy/open-1980-update-rest-server-to-ha…

c61c1aa

…ve-a-db-manager-process

aarushik93 disabled auto-merge December 1, 2024 15:28

aarushik93 enabled auto-merge December 1, 2024 15:28

aarushik93 previously approved these changes Dec 1, 2024

View reviewed changes

aarushik93 added this pull request to the merge queue Dec 1, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 1, 2024

Merge branch 'dev' into zamilmajdy/open-1980-update-rest-server-to-ha…

632335b

…ve-a-db-manager-process

majdyz enabled auto-merge December 1, 2024 22:56

feat(frontend): Make Block description searchable on Block list palette

23b5cea

majdyz dismissed aarushik93’s stale review via 23b5cea December 2, 2024 01:38

github-actions bot added size/m and removed size/s labels Dec 2, 2024

Merge branch 'dev' into zamilmajdy/open-1980-update-rest-server-to-ha…

23ce196

…ve-a-db-manager-process

majdyz disabled auto-merge December 2, 2024 01:50

majdyz added 2 commits December 2, 2024 09:01

Merge branch 'dev' into zamilmajdy/open-1980-update-rest-server-to-ha…

92dc367

…ve-a-db-manager-process

Merge branch 'dev' into zamilmajdy/open-1980-update-rest-server-to-ha…

0fa679b

…ve-a-db-manager-process

majdyz enabled auto-merge December 2, 2024 02:08

majdyz requested a review from aarushik93 December 2, 2024 07:50

Pwuts approved these changes Dec 2, 2024

View reviewed changes

majdyz added this pull request to the merge queue Dec 2, 2024

Merged via the queue into dev with commit 5c49fc8 Dec 2, 2024
19 checks passed

majdyz deleted the zamilmajdy/open-1980-update-rest-server-to-have-a-db-manager-process branch December 2, 2024 10:11

This was referenced Dec 2, 2024

Trigger backend CI on changes to autogpt_libs #8859

Closed

dx(backend): Fix linting & formatting for autogpt_libs #8860

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(backend): Apply lint on autogpt_lib folder on backend/linter.py #8751

refactor(backend): Apply lint on autogpt_lib folder on backend/linter.py #8751

majdyz commented Nov 25, 2024 •

edited

Loading

qodo-merge-pro bot commented Nov 25, 2024

netlify bot commented Nov 25, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 26, 2024

ntindle commented Nov 26, 2024

majdyz commented Nov 26, 2024 •

edited

Loading

aarushik93 commented Nov 26, 2024

majdyz commented Nov 27, 2024

netlify bot commented Nov 27, 2024 •

edited

Loading

ntindle commented Nov 29, 2024 •

edited

Loading

Pwuts left a comment

refactor(backend): Apply lint on autogpt_lib folder on backend/linter.py #8751

refactor(backend): Apply lint on autogpt_lib folder on backend/linter.py #8751

Conversation

majdyz commented Nov 25, 2024 • edited Loading

Changes 🏗️

Checklist 📋

For code changes:

For configuration changes:

qodo-merge-pro bot commented Nov 25, 2024

PR Reviewer Guide 🔍

netlify bot commented Nov 25, 2024 • edited Loading

✅ Deploy Preview for auto-gpt-docs canceled.

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 26, 2024

ntindle commented Nov 26, 2024

majdyz commented Nov 26, 2024 • edited Loading

aarushik93 commented Nov 26, 2024

majdyz commented Nov 27, 2024

netlify bot commented Nov 27, 2024 • edited Loading

✅ Deploy Preview for auto-gpt-docs-dev canceled.

ntindle commented Nov 29, 2024 • edited Loading

Pwuts left a comment

Choose a reason for hiding this comment

majdyz commented Nov 25, 2024 •

edited

Loading

netlify bot commented Nov 25, 2024 •

edited

Loading

majdyz commented Nov 26, 2024 •

edited

Loading

netlify bot commented Nov 27, 2024 •

edited

Loading

ntindle commented Nov 29, 2024 •

edited

Loading