Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): fix missing agent object requirement #9380

Merged
merged 3 commits into from
Feb 3, 2025
Merged

fix(backend): fix missing agent object requirement #9380

merged 3 commits into from
Feb 3, 2025

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Jan 30, 2025 •
edited
Loading

We oops'd and didn't return the agent as a downloadable

Changes 🏗️

  • attaches agent object

@ntindle ntindle requested a review from a team as a code owner January 30, 2025 21:33
@ntindle ntindle requested review from Bentlybro and majdyz and removed request for a team January 30, 2025 21:33
@supabase Supabase
Copy link

supabase bot commented Jan 30, 2025

This pull request has been ignored for the connected project bgwpwdsxblryihinutbx because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@qodo-merge-pro Qodo Merge Pro
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Error Handling

The query includes Agent data but the error handling still checks for store_listing_version.Agent without considering potential query failures

where={"id": store_listing_version_id},
include={"Agent": True},

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/s labels Jan 30, 2025
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Jan 30, 2025 •
edited
Loading

Here's the code health analysis summary for commits f1bc9d1..0388784. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 0388784
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/679cdd86ae8cd40008bc609a

@ntindle ntindle changed the title fix(backend): attach agent to returned object fix(backend): remove agent requirement from returned object Jan 31, 2025
@ntindle ntindle changed the title fix(backend): remove agent requirement from returned object fix(backend): fix missing agent object requirement Feb 3, 2025
@ntindle ntindle requested a review from Swiftyos February 3, 2025 10:55
@ntindle ntindle merged commit 53aea89 into master Feb 3, 2025
19 checks passed
@ntindle ntindle deleted the hotfix/attach-agent branch February 3, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftyos Swiftyos Swiftyos approved these changes

@Bentlybro Bentlybro Awaiting requested review from Bentlybro Bentlybro is a code owner automatically assigned from Significant-Gravitas/maintainers

@majdyz majdyz Awaiting requested review from majdyz majdyz is a code owner automatically assigned from Significant-Gravitas/maintainers

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end Review effort [1-5]: 1 size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntindle @Swiftyos