Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(block): Add batch matched result and its count on ExtractTextInformationBlock #9470

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Feb 12, 2025

Changes πŸ—οΈ

Introduced matched_result & matched_count as a batch matched result list and its count for the block execution of ExtractTextInformationBlock.

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested a review from a team as a code owner February 12, 2025 09:12
@majdyz majdyz requested review from ntindle and removed request for a team February 12, 2025 09:13
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
πŸ§ͺΒ PR contains tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Logic Change

The find_all behavior has been modified - previously it returned after first match, now it collects all matches and then slices. Verify this change maintains expected behavior.

if not input_data.find_all:
    matches = matches[:1]

Copy link

deepsource-io bot commented Feb 12, 2025

Here's the code health analysis summary for commits d050a3f..fab644e. View details on DeepSourceΒ β†—.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScriptβœ…Β SuccessView CheckΒ β†—
DeepSource Python LogoPythonβœ…Β SuccessView CheckΒ β†—

πŸ’‘ If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

netlify bot commented Feb 12, 2025

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit fab644e
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/67ac667c2f51d70008f137cf

@majdyz majdyz enabled auto-merge February 12, 2025 09:14
Copy link

netlify bot commented Feb 12, 2025

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit c8a47dc
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67ac661e5dddfc0008007c67
😎 Deploy Preview https://deploy-preview-9470--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 12, 2025

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit fab644e
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67ac667c8b1086000936e72a
😎 Deploy Preview https://deploy-preview-9470--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Bentlybro Bentlybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

@majdyz majdyz added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@majdyz majdyz added this pull request to the merge queue Feb 12, 2025
Merged via the queue into dev with commit 3b8cde6 Feb 12, 2025
23 checks passed
@majdyz majdyz deleted the zamilmajdy/add-batch-result-to-extract-information-block branch February 12, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants