Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding outflow term to the solver implementation #107

Open
1 task done
zasexton opened this issue Nov 7, 2023 · 2 comments
Open
1 task done

Adding outflow term to the solver implementation #107

zasexton opened this issue Nov 7, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@zasexton
Copy link

zasexton commented Nov 7, 2023

Problem

Currently the implementation of the svOneDSolver implicitly assumes no mass flux along the length of vessels (despite the original formulation including such terms wan02 (1).pdf but not in steele03.pdf).

Strong form with outflow term ($\psi$):
$$\dfrac{\partial S}{\partial t} + \dfrac{\partial Q}{\partial z} = -\psi$$

$$\dfrac{\partial Q}{\partial t} + \dfrac{\partial}{\partial z}((1+\delta)\dfrac{Q}{S}) + \dfrac{S}{\rho}\dfrac{\partial p}{\partial z} = Sf + N \dfrac{Q}{S} + \nu \dfrac{\partial^2 Q}{\partial z^2}$$

Solution

We intend to review the assumptions made during construction of the residual and stiffness matrix to ensure that the outflow term is properly included in the implementation (instead of assuming no net mass flux as is currently done).

Additional context

@mrp089 can you assign both @JRao-rgb and @zasexton to this issue

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@zasexton zasexton added the enhancement New feature or request label Nov 7, 2023
@mrp089
Copy link
Member

mrp089 commented Nov 7, 2023

I wish you two good digging on your archeological expedition! It could be useful to add comments to the terms that you reviewed.

@JRao-rgb
Copy link

Also modifying the relevant I/O procedures of the code so the parameters of the outflow function can be set from the input files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants