Added ability for solver to account for leakage in the vessel, as well as relevant test cases for validation. #109
Conversation
…t ran pytest -v lol
…'t print things like crazy
|
@mrp089 should be good to merge! Please take a look when you have time and let me know if I've missed anything! |
There was a problem hiding this comment.
Looks good, @JRao-rgb! Just some minor comments.
Please also update the ROM Simulation guide so others can see your new feature at the following places:
- input file (mention outflow option)
-
theory (mention
$\psi$ in the text)
Just follow the same process you did for this PR: fork the repository, create a branch, make the edits, open a PR (reference this PR - no need to create a new issue). The HTML will be generated automatically from the .md markdown files once the PR is merged.
Congratulations on adding the first new 1D feature in a long time!
Code/Source/cvOneDMaterial.h
Outdated
| @@ -218,7 +229,7 @@ double cvOneDMaterialOlufsen::GetD2pDS2(double area, double z)const{ | |||
| } | |||
|
|
|||
| double cvOneDMaterialOlufsen::GetOutflowFunction(double pressure, double z)const{ | |||
| return 0.0; // This is not used in our model | |||
| return L_P*(pressure - P_ambient); // JR 10/11/23: added function for outflow term | |||
| @@ -54,6 +54,10 @@ class cvOneDMaterialOlufsen:public cvOneDMaterial{ | |||
| void SetStop(double S){Stop = S;} | |||
| void SetSbottom(double S){Sbot = S;} | |||
| void SetLength(double length){len = length;} | |||
| void SetStarlingAmbientPressure(double value); | |||
| double GetStarlingAmbientPressure(); | |||
| double GetFoo() {return K1_;}; | |||
There was a problem hiding this comment.
Remove *.pyc and add to .gitignore with __pycache__
tests/cases/bifurcation_R.in
Outdated
There was a problem hiding this comment.
Check out from master branch since only formatting changed
Code/Source/cvOneDBFSolver.cxx
Outdated
…g time to converge for L_P = 1e-4, even though PREVIOUSLY it did not have this issue. I can't for the life of me remember what changed to get us here. I'm just committing this so I can switch the branch to master and then make a new branch where I hard-code in the outflow and see what happens. Break the least amount of shit and see what stays broken, right?
…ange the branch and start more systemmatically testing for what is making the convergence issue so shit. Stay tuned.
…ch with modified file I/O to look into convergence issues.
Current situation
#107
The solver didn't previous support leaky vessels. This has been fixed. The code is backwards-compatible with input files from older versions so the input files generated by the SimVascular GUI need not be modified.
Release Notes
Documentation
Testing
Code of Conduct & Contributing Guidelines