[squash] package up jestjs#3780

packages/babel-jest/src/index.js

@@ -15,15 +15,15 @@ import crypto from 'crypto';
 import fs from 'fs';
 import path from 'path';
 import jestPreset from 'babel-preset-jest';
+import {transform as babelTransform, util as babelUtil} from 'babel-core';
+import babelIstanbulPlugin from 'babel-plugin-istanbul';
 
 const BABELRC_FILENAME = '.babelrc';
 const BABELRC_JS_FILENAME = '.babelrc.js';
 const BABEL_CONFIG_KEY = 'babel';
 const PACKAGE_JSON = 'package.json';
 const THIS_FILE = fs.readFileSync(__filename);
 
-let babel;
-
 const createTransformer = (options: any) => {
   const cache = Object.create(null);
 
@@ -102,11 +102,7 @@ const createTransformer = (options: any) => {
       config: ProjectConfig,
       transformOptions: TransformOptions,
     ): string {
-      if (!babel) {
-        babel = require('babel-core');
-      }
-
-      if (babel.util && !babel.util.canCompile(filename)) {
+      if (babelUtil && !babelUtil.canCompile(filename)) {
         return src;
       }
 
@@ -116,7 +112,7 @@ const createTransformer = (options: any) => {
         // Copied from jest-runtime transform.js
         theseOptions.plugins = theseOptions.plugins.concat([
           [
-            require('babel-plugin-istanbul').default,
+            babelIstanbulPlugin,
             {
               // files outside `cwd` will not be instrumented
               cwd: config.rootDir,
@@ -126,7 +122,7 @@ const createTransformer = (options: any) => {
         ]);
       }
 
-      return babel.transform(src, theseOptions).code;
+      return babelTransform(src, theseOptions).code;
     },
   };
 };

packages/babel-preset-jest/index.js

@@ -8,6 +8,7 @@
 
 module.exports = {
   plugins: [
+    // Cannot be `import` as this file is not compiled
     require('babel-plugin-jest-hoist'),
   ],
 };

packages/eslint-config-fb-strict/index.js

@@ -7,7 +7,7 @@
  *
  */
 
-// Can't be ESModules as this is not transpiled
+// Can't be ESModules as this is not compiled
 const fbjsConfig = require('eslint-config-fbjs');
 
 const variableNamePattern = String.raw`\s*[a-zA-Z_$][a-zA-Z_$\d]*\s*`;

packages/eslint-plugin-jest/src/index.js

@@ -8,6 +8,11 @@
  * @flow
  */
 
+import noDisabledTests from './rules/no-disabled-tests';
+import noFocusedTests from './rules/no-focused-tests';
+import noIdenticalTitle from './rules/no-identical-title';
+import validExpect from './rules/valid-expect';
+
 module.exports = {
   configs: {
     recommended: {
@@ -42,9 +47,9 @@ module.exports = {
     },
   },
   rules: {
-    'no-disabled-tests': require('./rules/no-disabled-tests'),
-    'no-focused-tests': require('./rules/no-focused-tests'),
-    'no-identical-title': require('./rules/no-identical-title'),
-    'valid-expect': require('./rules/valid-expect'),
+    'no-disabled-tests': noDisabledTests,
+    'no-focused-tests': noFocusedTests,
+    'no-identical-title': noIdenticalTitle,
+    'valid-expect': validExpect,
   },
 };

packages/jest-changed-files/src/index.js

@@ -8,7 +8,10 @@
  * @flow
  */
 
+import git from './git';
+import hg from './hg';
+
 module.exports = {
-  git: require('./git'),
-  hg: require('./hg'),
+  git,
+  hg,
 };

packages/jest-cli/src/TestNamePatternPrompt.js

@@ -9,6 +9,7 @@
  */
 
 import type {TestResult} from 'types/TestResult';
+import chalk from 'chalk';
 import type {ScrollOptions} from './lib/scrollList';
 
 import scroll from './lib/scrollList';
@@ -53,7 +54,7 @@ module.exports = class TestNamePatternPrompt extends PatternPrompt {
         total,
         'test',
         pipe,
-        ` from ${require('chalk').yellow('cached')} test suites`,
+        ` from ${chalk.yellow('cached')} test suites`,
       );
 
       const width = getTerminalWidth();

packages/jest-cli/src/TestRunner.js

@@ -29,6 +29,7 @@ import SummaryReporter from './reporters/SummaryReporter';
 import VerboseReporter from './reporters/VerboseReporter';
 import runTest from './runTest';
 import TestWatcher from './TestWatcher';
+import CoverageReporter from './reporters/CoverageReporter';
 import ReporterDispatcher from './ReporterDispatcher';
 
 const SLOW_TEST_TIME = 3000;
@@ -295,9 +296,6 @@ class TestRunner {
     }
 
     if (collectCoverage) {
-      // coverage reporter dependency graph is pretty big and we don't
-      // want to require it if we're not in the `--coverage` mode
-      const CoverageReporter = require('./reporters/CoverageReporter');
       this.addReporter(
         new CoverageReporter(this._globalConfig, {
           maxWorkers: this._options.maxWorkers,

packages/jest-cli/src/cli/getJest.js

@@ -21,6 +21,7 @@ function getJest(packageRoot: Path) {
     /* $FlowFixMe */
     return require(binPath);
   } else {
+    // TODO: Because of a dependency cycle, this can only be inlined once the babel plugin for inlining is merged
     const jest = require('../jest');
     // Check if Jest is specified in `package.json` but not installed.
     if (fs.existsSync(packageJSONPath)) {

packages/jest-cli/src/reporters/CoverageReporter.js

@@ -31,6 +31,7 @@ import libSourceMaps from 'istanbul-lib-source-maps';
 import pify from 'pify';
 import workerFarm from 'worker-farm';
 import BaseReporter from './BaseReporter';
+import CoverageWorker from './CoverageWorker';
 
 const FAIL_COLOR = chalk.bold.red;
 const RUNNING_TEST_COLOR = chalk.bold.dim;
@@ -143,7 +144,7 @@ class CoverageReporter extends BaseReporter {
     let worker;
     let farm;
     if (this._maxWorkers <= 1) {
-      worker = pify(require('./CoverageWorker'));
+      worker = pify(CoverageWorker);
     } else {
       farm = workerFarm(
         {

packages/jest-config/src/deprecated.js

@@ -9,8 +9,9 @@
  */
 
 import chalk from 'chalk';
+import prettyFormat from 'pretty-format';
 
-const format = (value: mixed) => require('pretty-format')(value, {min: true});
+const format = (value: mixed) => prettyFormat(value, {min: true});
 
 const deprecatedOptions = {
   preprocessorIgnorePatterns: (options: {

packages/jest-environment-jsdom/src/index.js

@@ -14,6 +14,7 @@ import type {ModuleMocker} from 'jest-mock';
 
 import {FakeTimers, installCommonGlobals} from 'jest-util';
 import mock from 'jest-mock';
+import JSDom from 'jsdom';
 
 class JSDOMEnvironment {
   document: ?Object;
@@ -23,7 +24,7 @@ class JSDOMEnvironment {
 
   constructor(config: ProjectConfig): void {
     // lazy require
-    this.document = require('jsdom').jsdom(/* markup */ undefined, {
+    this.document = JSDom.jsdom(/* markup */ undefined, {
       url: config.testURL,
     });
     const global = (this.global = this.document.defaultView);
@@ -50,7 +51,7 @@ class JSDOMEnvironment {
 
   runScript(script: Script): ?any {
     if (this.global) {
-      return require('jsdom').evalVMScript(this.global, script);
+      return JSDom.evalVMScript(this.global, script);
     }
     return null;
   }

packages/jest-resolve/src/index.js

@@ -15,6 +15,7 @@ import fs from 'fs';
 import path from 'path';
 import nodeModulesPaths from 'resolve/lib/node-modules-paths';
 import isBuiltinModule from 'is-builtin-module';
+import defaultResolver from './defaultResolver.js';
 
 type ResolverConfig = {|
   browser?: boolean,
@@ -89,8 +90,10 @@ class Resolver {
   }
 
   static findNodeModule(path: Path, options: FindNodeModuleConfig): ?Path {
-    /* $FlowFixMe */
-    const resolver = require(options.resolver || './defaultResolver.js');
+    const resolver = options.resolver
+      ? /* $FlowFixMe */
+        require(options.resolver)
+      : defaultResolver;
     const paths = options.paths;
 
     try {

packages/jest-runtime/src/ScriptTransformer.js

@@ -20,6 +20,9 @@ import path from 'path';
 import vm from 'vm';
 import {createDirectory} from 'jest-util';
 import fs from 'graceful-fs';
+import {transform as babelTransform} from 'babel-core';
+import babelPluginIstanbul from 'babel-plugin-istanbul';
+import convertSourceMap from 'convert-source-map';
 // $FlowFixMe: Missing ESM export
 import {getCacheFilePath} from 'jest-haste-map';
 import stableStringify from 'json-stable-stringify';
@@ -148,12 +151,7 @@ class ScriptTransformer {
   }
 
   _instrumentFile(filename: Path, content: string): string {
-    // Keeping these requires inside this function reduces a single run
-    // time by 2sec if not running in `--coverage` mode
-    const babel = require('babel-core');
-    const babelPluginIstanbul = require('babel-plugin-istanbul').default;
-
-    return babel.transform(content, {
+    return babelTransform(content, {
       auxiliaryCommentBefore: ' istanbul ignore next ',
       babelrc: false,
       filename,
@@ -217,8 +215,7 @@ class ScriptTransformer {
 
     if (mapCoverage) {
       if (!transformed.map) {
-        const convert = require('convert-source-map');
-        const inlineSourceMap = convert.fromSource(transformed.code);
+        const inlineSourceMap = convertSourceMap.fromSource(transformed.code);
         if (inlineSourceMap) {
           transformed.map = inlineSourceMap.toJSON();
         }

packages/jest-runtime/src/cli/index.js

@@ -17,10 +17,11 @@ import chalk from 'chalk';
 import yargs from 'yargs';
 import {Console, setGlobal, validateCLIOptions} from 'jest-util';
 import {readConfig} from 'jest-config';
-const VERSION = (require('../../package.json').version: string);
 import Runtime from '../';
 import args from './args';
 
+const VERSION = (require('../../package.json').version: string);
+
 function run(cliArgv?: Argv, cliInfo?: Array<string>) {
   let argv;
   if (cliArgv) {

packages/jest-runtime/src/index.js

@@ -25,6 +25,7 @@ import fs from 'graceful-fs';
 import stripBOM from 'strip-bom';
 import ScriptTransformer from './ScriptTransformer';
 import shouldInstrument from './shouldInstrument';
+import cliArgs from './cli/args';
 
 type Module = {|
   children?: Array<any>,
@@ -260,11 +261,12 @@ class Runtime {
   }
 
   static runCLI(args?: Argv, info?: Array<string>) {
+    // TODO: If this is not inline, the repl test fails
     return require('./cli').run(args, info);
   }
 
   static getCLIOptions() {
-    return require('./cli/args').options;
+    return cliArgs.options;
   }
 
   requireModule(

packages/jest-validate/src/index.js

@@ -8,10 +8,14 @@
  * @flow
  */
 
+import {createDidYouMeanMessage, format, logValidationWarning} from './utils';
+import {ValidationError} from './errors';
+import validate from './validate';
+
 module.exports = {
-  ValidationError: require('./errors').ValidationError,
-  createDidYouMeanMessage: require('./utils').createDidYouMeanMessage,
-  format: require('./utils').format,
-  logValidationWarning: require('./utils').logValidationWarning,
-  validate: require('./validate'),
+  ValidationError,
+  createDidYouMeanMessage,
+  format,
+  logValidationWarning,
+  validate,
 };

packages/jest-validate/src/utils.js

@@ -9,6 +9,8 @@
  */
 
 import chalk from 'chalk';
+import prettyFormat from 'pretty-format';
+import leven from 'leven';
 
 const BULLET: string = chalk.bold('\u25cf');
 const DEPRECATION = `${BULLET} Deprecation Warning`;
@@ -18,7 +20,7 @@ const WARNING = `${BULLET} Validation Warning`;
 const format = (value: any): string =>
   typeof value === 'function'
     ? value.toString()
-    : require('pretty-format')(value, {min: true});
+    : prettyFormat(value, {min: true});
 
 class ValidationError extends Error {
   name: string;
@@ -46,7 +48,6 @@ const createDidYouMeanMessage = (
   unrecognized: string,
   allowedOptions: Array<string>,
 ) => {
-  const leven = require('leven');
   const suggestion = allowedOptions.find(option => {
     const steps: number = leven(option, unrecognized);
     return steps < 3;

packages/jest/src/jest.js

@@ -8,4 +8,6 @@
  * @flow
  */
 
-module.exports = require('jest-cli');
+import cli from 'jest-cli';
+
+module.exports = cli;

packages/pretty-format/src/index.js

@@ -18,6 +18,13 @@ import type {
 
 import style from 'ansi-styles';
 
+import AsymmetricMatcher from './plugins/AsymmetricMatcher';
+import ConvertAnsi from './plugins/ConvertAnsi';
+import HTMLElement from './plugins/HTMLElement';
+import Immutable from './plugins/ImmutablePlugins';
+import ReactElement from './plugins/ReactElement';
+import ReactTestComponent from './plugins/ReactTestComponent';
+
 type Theme = {|
   comment?: string,
   content?: string,
@@ -959,12 +966,12 @@ function prettyFormat(val: any, initialOptions?: InitialOptions): string {
 }
 
 prettyFormat.plugins = {
-  AsymmetricMatcher: require('./plugins/AsymmetricMatcher'),
-  ConvertAnsi: require('./plugins/ConvertAnsi'),
-  HTMLElement: require('./plugins/HTMLElement'),
-  Immutable: require('./plugins/ImmutablePlugins'),
-  ReactElement: require('./plugins/ReactElement'),
-  ReactTestComponent: require('./plugins/ReactTestComponent'),
+  AsymmetricMatcher,
+  ConvertAnsi,
+  HTMLElement,
+  Immutable,
+  ReactElement,
+  ReactTestComponent,
 };
 
 module.exports = prettyFormat;

packages/pretty-format/src/plugins/ConvertAnsi.js

@@ -11,9 +11,9 @@
 import type {Colors, Indent, Options, Print, Plugin} from 'types/PrettyFormat';
 
 import ansiRegex from 'ansi-regex';
+import style from 'ansi-styles';
 
 const toHumanReadableAnsi = text => {
-  const style = require('ansi-styles');
   return text.replace(ansiRegex(), (match, offset, string) => {
     switch (match) {
       case style.red.close: