Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICONS remains activated when other icon selected #44

Closed
karagarwal opened this issue Oct 13, 2022 · 4 comments · Fixed by #45
Closed

ICONS remains activated when other icon selected #44

karagarwal opened this issue Oct 13, 2022 · 4 comments · Fixed by #45

Comments

@karagarwal
Copy link

If we switched between menu too quickly then strange phenomena is observed,
I am attaching Screen Recording for reference

Note: This this is observed while performing Negative Testing.
Please help with some kind of workaround for same

Screenrecorder-2022-10-13-12-17-54-336.mp4
@AshvinVavaliya
Copy link
Collaborator

Hi karagarwal,
Sorry for late, We are finding proper solution for this issue and update you ASAP.

@AshvinVavaliya
Copy link
Collaborator

Hello karagarwal
Your issue is fixed, try it out with latest version and let me know.

@karagarwal
Copy link
Author

karagarwal commented May 1, 2023

Hello @AshvinVavaliya
Thanks for the reply the issue was fixed in 3.5, but recent changes now it leads to one major bug
Details:
File : custombottomnavigation/src/main/java/com/simform/custombottomnavigation/SSCustomBottomNavigation.kt
line 222 & 226
//Current Code

if (TextUtils.isEmpty(iconTextTypeFace))    //Line 222
 if (TextUtils.isEmpty(typeface))                 //line 226

//What should be

if (!iconTextTypeFace.isNullOrBlank())        //line 222
   if (!typeface.isNullOrBlank())                     //line 226

What Causing Bug:
If typeface attributes are not used in XML Component then it will lead to crash

How Bug Arsie
in Update v3.5 the conditions got reversed from null_empty to empty

Screenshots
Screenshot_2

@AshvinVavaliya
Copy link
Collaborator

AshvinVavaliya commented May 1, 2023

Hi @karagarwal
Sorry, my bad,
I'll update this ASAP
Thanks to you for this valuable information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants