Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom view is not displayed when refreshing manually #29

Closed
javichaques opened this issue Mar 31, 2023 · 11 comments · Fixed by #30, #31 or #33
Closed

Custom view is not displayed when refreshing manually #29

javichaques opened this issue Mar 31, 2023 · 11 comments · Fixed by #30, #31 or #33
Assignees
Labels
bug Something isn't working

Comments

@javichaques
Copy link

Hi, i have implemented a custom refresh view using version 1.5 from library and it works perfectly when swipe but is not visible when call setRefreshing from code.
My custom view is a Constraint layout with a lottie animation and TextView.

In this video you can view when I click the "chip button" the refresh view is not visible.
Thanks!

pull-to-refresh.webm
@javichaques javichaques added the bug Something isn't working label Mar 31, 2023
nishchal-v added a commit that referenced this issue Mar 31, 2023
nishchal-v added a commit that referenced this issue Mar 31, 2023
@nishchal-v nishchal-v self-assigned this Mar 31, 2023
@yashwantgowla-simform yashwantgowla-simform linked a pull request Apr 3, 2023 that will close this issue
yashwantgowla-simform added a commit that referenced this issue Apr 3, 2023
…om=-view-is-not-displayed-when-refreshing-manually

UNT-T15621 🐞 Bugfix: #29

LGTM.
@nishchal-v nishchal-v linked a pull request Apr 3, 2023 that will close this issue
@nishchal-v nishchal-v reopened this Apr 3, 2023
yashwantgowla-simform added a commit that referenced this issue Apr 3, 2023
…om=-view-is-not-displayed-when-refreshing-manually

UNT-T15621 🐞 Bugfix: #29

LGTM.
@nishchal-v
Copy link
Collaborator

@javichaques Please find this issue fixed in latest release 1.5.1

@javichaques
Copy link
Author

Hi @nishchal-v , thanks for quick reply
I just tried the new version and it only shows the loader the first time, the second time I call setRefreshing(true) the loader is not shown

@nishchal-v nishchal-v reopened this Apr 3, 2023
@nishchal-v
Copy link
Collaborator

@javichaques I have found the cause for your issue, I'll fix it with a PR soon.

nishchal-v added a commit that referenced this issue Apr 3, 2023
@nishchal-v nishchal-v linked a pull request Apr 3, 2023 that will close this issue
yashwantgowla-simform added a commit that referenced this issue Apr 3, 2023
…BugFix-View-Gone-When-Rest-callabck-recieved

UNT-T15621 🐞 Bugfix: #29

LGTM.
@nishchal-v
Copy link
Collaborator

@javichaques Let me know whether the issue is resolved or not. Then I'll close this issue.

@javichaques
Copy link
Author

@javichaques Let me know whether the issue is resolved or not. Then I'll close this issue.

I keep having the same issue

@nishchal-v
Copy link
Collaborator

nishchal-v commented Apr 3, 2023

You can check out the CustomViewDemo branch and run the demo project.
Let me know is the difference in your and mine implementations.

@javichaques
Copy link
Author

It seems that it doesn't work with version 1.5.1, I've tried with the version directly from the commit and it works correctly.
implementation 'com.github.SimformSolutionsPvtLtd:SSPullToRefresh:d729ad745d'

@nishchal-v
Copy link
Collaborator

yes, if you use implementation 'com.github.SimformSolutionsPvtLtd:SSPullToRefresh:main-SNAPSHOT' it downloads the fixed changes but does not work with tag.
So there are some issue with tag. Most probably this could issue from Jitpack side.

@javichaques
Copy link
Author

yes, if you use implementation 'com.github.SimformSolutionsPvtLtd:SSPullToRefresh:main-SNAPSHOT' it downloads the fixed changes but does not work with tag. So there are some issue with tag. Most probably this could issue from Jitpack side.

I think the problem is because a version with the same tag has been generated, perhaps it should be uploaded to 1.5.2

@nishchal-v
Copy link
Collaborator

The versioning is related to tag and the tag is already moved to latest commit d729ad7.
Also the Jitpack page shows using the same commit hash d729ad7 for builds of 1.5.1.

So fetching 1.5.1 should be downloaded with latest changes.

@nishchal-v
Copy link
Collaborator

@javichaques Please clear your gradle cache, it should work just fine.
Here is an helpful SO answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants