feat: 🌟 listen to typing indicator changes better

SimformSolutionsPvtLtd · Jun 17, 2024 · 800871f · 800871f
1 parent 232214c
commit 800871f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 30 deletions.
diff --git a/lib/src/widgets/chat_groupedlist_widget.dart b/lib/src/widgets/chat_groupedlist_widget.dart
@@ -33,7 +33,6 @@ class ChatGroupedListWidget extends StatefulWidget {
   const ChatGroupedListWidget({
     Key? key,
     required this.showPopUp,
-    required this.showTypingIndicator,
     required this.scrollController,
     required this.chatBackgroundConfig,
     required this.replyMessage,
@@ -52,8 +51,7 @@ class ChatGroupedListWidget extends StatefulWidget {
   /// Allow user to swipe to see time while reaction pop is not open.
   final bool showPopUp;
 
-  /// Allow user to show typing indicator.
-  final bool showTypingIndicator;
+  /// Pass scroll controller
   final ScrollController scrollController;
 
   /// Allow user to give customisation to background of chat
@@ -103,8 +101,6 @@ class _ChatGroupedListWidgetState extends State<ChatGroupedListWidget>
 
   bool get showPopUp => widget.showPopUp;
 
-  bool get showTypingIndicator => widget.showTypingIndicator;
-
   bool highlightMessage = false;
   final ValueNotifier<String?> _replyId = ValueNotifier(null);
 
@@ -184,7 +180,6 @@ class _ChatGroupedListWidgetState extends State<ChatGroupedListWidget>
       reverse: true,
       // When reaction popup is being appeared at that user should not scroll.
       physics: showPopUp ? const NeverScrollableScrollPhysics() : null,
-      padding: EdgeInsets.only(bottom: showTypingIndicator ? 50 : 0),
       controller: widget.scrollController,
       child: Column(
         mainAxisSize: MainAxisSize.min,
@@ -210,23 +205,19 @@ class _ChatGroupedListWidgetState extends State<ChatGroupedListWidget>
                   )
                 : _chatStreamBuilder,
           ),
-          widget.showTypingIndicator
-              ? TypingIndicator(
-                  typeIndicatorConfig: widget.typeIndicatorConfig,
-                  chatBubbleConfig: chatBubbleConfig?.inComingChatBubbleConfig,
-                  showIndicator: widget.showTypingIndicator,
-                )
-              : ValueListenableBuilder(
-                  valueListenable: ChatViewInheritedWidget.of(context)!
-                      .chatController
-                      .typingIndicatorNotifier,
-                  builder: (context, value, child) => TypingIndicator(
+          ValueListenableBuilder(
+            valueListenable: ChatViewInheritedWidget.of(context)!
+                .chatController
+                .typingIndicatorNotifier,
+            builder: (context, value, child) => value
+                ? TypingIndicator(
                     typeIndicatorConfig: widget.typeIndicatorConfig,
                     chatBubbleConfig:
                         chatBubbleConfig?.inComingChatBubbleConfig,
                     showIndicator: value,
-                  ),
-                ),
+                  )
+                : Container(),
+          ),
           Flexible(
             child: Align(
               alignment: suggestionsListConfig.axisAlignment.alignment,

diff --git a/lib/src/widgets/chat_list_widget.dart b/lib/src/widgets/chat_list_widget.dart
@@ -36,7 +36,6 @@ class ChatListWidget extends StatefulWidget {
     Key? key,
     required this.chatController,
     required this.chatBackgroundConfig,
-    required this.showTypingIndicator,
     required this.assignReplyMessage,
     required this.replyMessage,
     this.loadingWidget,
@@ -63,9 +62,6 @@ class ChatListWidget extends StatefulWidget {
   /// Provides widget for loading view while pagination is enabled.
   final Widget? loadingWidget;
 
-  /// Provides flag for turn on/off typing indicator.
-  final bool showTypingIndicator;
-
   /// Provides configuration for reaction pop up appearance.
   final ReactionPopupConfiguration? reactionPopupConfig;
 
@@ -128,8 +124,6 @@ class _ChatListWidgetState extends State<ChatListWidget>
 
   ScrollController get scrollController => chatController.scrollController;
 
-  bool get showTypingIndicator => widget.showTypingIndicator;
-
   ChatBackgroundConfiguration get chatBackgroundConfig =>
       widget.chatBackgroundConfig;
 
@@ -193,7 +187,6 @@ class _ChatListWidgetState extends State<ChatListWidget>
                 children: [
                   ChatGroupedListWidget(
                     showPopUp: showPopupValue,
-                    showTypingIndicator: showTypingIndicator,
                     scrollController: scrollController,
                     isEnableSwipeToSeeTime:
                         featureActiveConfig?.enableSwipeToSeeTime ?? true,

diff --git a/lib/src/widgets/chat_view.dart b/lib/src/widgets/chat_view.dart
@@ -164,8 +164,6 @@ class _ChatViewState extends State<ChatView>
 
   ChatController get chatController => widget.chatController;
 
-  // bool get showTypingIndicator => widget.showTypingIndicator;
-
   ChatBackgroundConfiguration get chatBackgroundConfig =>
       widget.chatBackgroundConfig;
 
@@ -249,8 +247,6 @@ class _ChatViewState extends State<ChatView>
                           valueListenable: replyMessage,
                           builder: (_, state, child) {
                             return ChatListWidget(
-                              showTypingIndicator:
-                                  chatController.showTypingIndicator,
                               replyMessage: state,
                               chatController: widget.chatController,
                               chatBackgroundConfig: widget.chatBackgroundConfig,