Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨add default avatar profile image, cached network image for network images and image type to support profile image as asset, network or base64 data #172

Merged
merged 2 commits into from
Jun 4, 2024
Merged

feat: ✨add default avatar profile image, cached network image for network images and image type to support profile image as asset, network or base64 data #172

merged 2 commits into from
Jun 4, 2024

Conversation

apurva010
Copy link
Collaborator

Description

  • Add default avatar for profile image, cached network image for network images and image type to support profile image as asset, network or base64 data.
  • Add error builder for all type of image networkImageErrorBuilder for network and assetImageErrorBuilder for asset as well as base64 data.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@apurva010 apurva010 mentioned this pull request May 23, 2024
Closed
7 tasks
@apurva010 apurva010 force-pushed the feat/default_avatar_image_and_image_type branch from df2a70c to d580a0a Compare May 24, 2024 05:22
This was linked to issues May 27, 2024
Cached Network Image for Chat background #147
Closed
Missing customization options #133
Closed
@apurva010 apurva010 force-pushed the feat/default_avatar_image_and_image_type branch from d580a0a to 375bec1 Compare May 30, 2024 13:39
aditya-css
aditya-css requested changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@aditya-css aditya-css left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if you can utilise InheritedWidget for accessing parameters. Also, look into progress indicator for network images.

lib/src/extensions/extensions.dart Outdated Show resolved Hide resolved
lib/src/models/chat_user.dart Outdated Show resolved Hide resolved
lib/src/models/chat_user.dart Show resolved Hide resolved
lib/src/values/enumaration.dart Outdated Show resolved Hide resolved
lib/src/widgets/profile_circle.dart Outdated Show resolved Hide resolved
lib/src/widgets/profile_image_widget.dart Outdated Show resolved Hide resolved
lib/src/widgets/profile_image_widget.dart Outdated Show resolved Hide resolved
lib/src/widgets/profile_image_widget.dart Outdated Show resolved Hide resolved
@apurva010
feat: ✨add default avatar profile image, cached network image for net…
34df674 
…work images and image type to support profile image as asset, network or base64 data
@apurva010 apurva010 force-pushed the feat/default_avatar_image_and_image_type branch 2 times, most recently from 1b2e1d2 to 321c8e8 Compare June 4, 2024 09:27
@apurva010 apurva010 force-pushed the feat/default_avatar_image_and_image_type branch from 321c8e8 to e7e9ad2 Compare June 4, 2024 11:24
@aditya-css aditya-css merged commit 585e943 into main Jun 4, 2024
@aditya-css aditya-css deleted the feat/default_avatar_image_and_image_type branch June 4, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-css aditya-css aditya-css approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cached Network Image for Chat background Missing customization options
2 participants
@apurva010 @aditya-css