Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: 🐛 json parsing issue #178

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix!: 🐛 json parsing issue #178

merged 2 commits into from
Jun 6, 2024

Conversation

dhyash-simform
Copy link
Collaborator

  • Added tryParse methods in MessageType, MessageStatus in enumaration.dart
  • Fixed fromJson(), toJson() methods in message.dart, reaction.dart, reply_message.dart

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@dhyash-simform dhyash-simform force-pushed the fix/json-parsing-issue branch from 9587b2d to 34e2fb1 Compare May 31, 2024 10:21
@dhyash-simform dhyash-simform changed the title fix: 🐛 fix/Json Parsing Issue fix: 🐛 json Parsing Issue May 31, 2024
@dhyash-simform dhyash-simform changed the title fix: 🐛 json Parsing Issue fix: 🐛 json parsing issue May 31, 2024
aditya-css
aditya-css requested changes Jun 3, 2024
View reviewed changes
lib/src/models/message.dart Outdated Show resolved Hide resolved
lib/src/models/message.dart Outdated Show resolved Hide resolved
lib/src/models/message.dart Outdated Show resolved Hide resolved
lib/src/models/reaction.dart Outdated Show resolved Hide resolved
lib/src/models/reply_message.dart Outdated Show resolved Hide resolved
@apurva010 apurva010 force-pushed the fix/json-parsing-issue branch 2 times, most recently from 8859a84 to 0db0030 Compare June 6, 2024 08:19
aditya-css
aditya-css requested changes Jun 6, 2024
View reviewed changes
lib/src/models/message.dart Show resolved Hide resolved
lib/src/models/chat_user.dart Outdated Show resolved Hide resolved
lib/src/models/message.dart Outdated Show resolved Hide resolved
lib/src/models/reply_message.dart Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@apurva010 apurva010 force-pushed the fix/json-parsing-issue branch from 0db0030 to dc914eb Compare June 6, 2024 09:58
dhyash-simform and others added 2 commits June 6, 2024 15:35
@dhyash-simform @apurva010
fix!: 🐛 fix/Json Parsing Issue
df6fe2d 
- Added tryParse methods in `MessageType`, `MessageStatus` in `enumaration.dart`
- Fixed `fromJson()`, `toJson()` methods in `message.dart`, `reaction.dart`, `reply_message.dart`
@apurva010
fix!: 🐛 added copyWith methods for model
29f3866
@apurva010 apurva010 force-pushed the fix/json-parsing-issue branch from dc914eb to 29f3866 Compare June 6, 2024 10:05
@apurva010 apurva010 changed the title fix: 🐛 json parsing issue fix!: 🐛 json parsing issue Jun 6, 2024
@aditya-css aditya-css merged commit 2e3eccf into main Jun 6, 2024
@aditya-css aditya-css deleted the fix/json-parsing-issue branch June 6, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-css aditya-css aditya-css approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhyash-simform @aditya-css @apurva010