Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: 🔨 update sendBy parameter name of Message class to sentBy #188

Merged
merged 1 commit into from
Jun 18, 2024
Merged

refactor!: 🔨 update sendBy parameter name of Message class to sentBy #188

merged 1 commit into from
Jun 18, 2024

Conversation

vatsaltanna-simformsolutions
Copy link
Collaborator

@vatsaltanna-simformsolutions vatsaltanna-simformsolutions commented Jun 13, 2024 •
edited
Loading

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@vatsaltanna-simformsolutions vatsaltanna-simformsolutions mentioned this pull request Jun 13, 2024
Closed
aditya-css
aditya-css requested changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@aditya-css aditya-css left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add exclamation mark to the commit message and change it to refactor?
i.e. refactor!:

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@vatsaltanna-simformsolutions vatsaltanna-simformsolutions changed the title fix: 🔨 update sendBy parameter name of Message class to sentBy refactor!: 🔨 update sendBy parameter name of Message class to sentBy Jun 18, 2024
@aditya-css aditya-css merged commit 34a29c8 into main Jun 18, 2024
@aditya-css aditya-css deleted the fix/send_by_spelling_change branch June 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-css aditya-css aditya-css approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vatsaltanna-simformsolutions @aditya-css