Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: 🔨 Move currentUser into ChatController from ChatView widget and rename chatUsers to otherUsers #190

Merged
merged 1 commit into from
Jun 18, 2024
Merged

refactor!: 🔨 Move currentUser into ChatController from ChatView widget and rename chatUsers to otherUsers #190

merged 1 commit into from
Jun 18, 2024

Conversation

vatsaltanna-simformsolutions
Copy link
Collaborator

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@vatsaltanna-simformsolutions vatsaltanna-simformsolutions mentioned this pull request Jun 14, 2024
Draft
7 tasks
@vatsaltanna-simformsolutions vatsaltanna-simformsolutions force-pushed the fix/current_chat_user_in_chat_controller branch from d240da4 to ac01422 Compare June 14, 2024 05:50
jonasbadstuebner
jonasbadstuebner reviewed Jun 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
aditya-css
aditya-css requested changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@aditya-css aditya-css left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the commit message to use refactor!: instead of fix:.

lib/src/widgets/chat_bubble_widget.dart Outdated Show resolved Hide resolved
lib/src/widgets/chat_view.dart Outdated Show resolved Hide resolved
lib/src/widgets/reaction_popup.dart Outdated Show resolved Hide resolved
lib/src/widgets/reply_message_widget.dart Outdated Show resolved Hide resolved
lib/src/controller/chat_controller.dart Outdated Show resolved Hide resolved
lib/src/controller/chat_controller.dart Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@vatsaltanna-simformsolutions vatsaltanna-simformsolutions force-pushed the fix/current_chat_user_in_chat_controller branch 4 times, most recently from 8e7d400 to 3b750ac Compare June 18, 2024 12:50
@vatsaltanna-simformsolutions vatsaltanna-simformsolutions changed the title Fix/current chat user in chat controller refactor!: 🔨 Move currentUser into ChatController from ChatView widget and rename chatUsers to otherUsers Jun 18, 2024
@vatsaltanna-simformsolutions vatsaltanna-simformsolutions force-pushed the fix/current_chat_user_in_chat_controller branch 6 times, most recently from c3397ca to 6604dca Compare June 18, 2024 13:52
@vatsaltanna-simformsolutions vatsaltanna-simformsolutions force-pushed the fix/current_chat_user_in_chat_controller branch from 6604dca to 86d27bd Compare June 18, 2024 13:53
@aditya-css aditya-css merged commit 4c9b6ad into main Jun 18, 2024
@aditya-css aditya-css deleted the fix/current_chat_user_in_chat_controller branch June 18, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasbadstuebner jonasbadstuebner jonasbadstuebner left review comments

@aditya-css aditya-css aditya-css approved these changes

@apurva010 apurva010 Awaiting requested review from apurva010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vatsaltanna-simformsolutions @jonasbadstuebner @aditya-css