Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 correct usage of provide after unmount #191

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: 🐛 correct usage of provide after unmount #191

merged 1 commit into from
Jun 18, 2024

Conversation

jonasbadstuebner
Copy link
Contributor

@jonasbadstuebner jonasbadstuebner commented Jun 17, 2024 •
edited
Loading

Description

When using provide I got some error messages that could all be prevented at the root by checking if the state is mounted.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

#187

@jonasbadstuebner
Copy link
Contributor Author

Part of #187

aditya-css
aditya-css requested changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@aditya-css aditya-css left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please do this for other extensions related to inherited widget as well?

@jonasbadstuebner jonasbadstuebner force-pushed the fix-provide-usage-after-unmount branch from 9cbfcc8 to 2f1b7dd Compare June 18, 2024 15:46
@aditya-css
Copy link
Collaborator

Thanks @jonasbadstuebner. Can you please mention this commit in changelog as well?

@jonasbadstuebner jonasbadstuebner force-pushed the fix-provide-usage-after-unmount branch from 2f1b7dd to ff1897b Compare June 18, 2024 15:53
@jonasbadstuebner
Copy link
Contributor Author

@aditya-css Like so?

aditya-css
aditya-css requested changes Jun 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jonasbadstuebner jonasbadstuebner force-pushed the fix-provide-usage-after-unmount branch from ff1897b to 7d1f066 Compare June 18, 2024 16:03
@aditya-css aditya-css merged commit 08da145 into SimformSolutionsPvtLtd:main Jun 18, 2024
@jonasbadstuebner jonasbadstuebner mentioned this pull request Jun 18, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-css aditya-css aditya-css approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasbadstuebner @aditya-css