Calculation tooltip position #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faiyaz-shaikh
force-pushed
the
fix/tooltip_position_calculation
branch
from
4fc3280 to
e316d99
Compare
Closed
vatsaltanna
reviewed
Feb 24, 2022
lib/src/tooltip_widget.dart
Outdated
| @@ -82,7 +82,10 @@ class _ToolTipWidgetState extends State<ToolTipWidget> | |||
| bool isCloseToTopOrBottom(Offset position) { | |||
| var height = 120.0; | |||
| height = widget.contentHeight ?? height; | |||
| return (widget.screenSize!.height - position.dy) <= height; | |||
| var bottomPosition = position.dy + (widget.position!.getHeight() / 2); | |||
There was a problem hiding this comment.
use final and handle the force unwrap
lib/src/tooltip_widget.dart
Outdated
| @@ -82,7 +82,10 @@ class _ToolTipWidgetState extends State<ToolTipWidget> | |||
| bool isCloseToTopOrBottom(Offset position) { | |||
| var height = 120.0; | |||
| height = widget.contentHeight ?? height; | |||
| return (widget.screenSize!.height - position.dy) <= height; | |||
| var bottomPosition = position.dy + (widget.position!.getHeight() / 2); | |||
| var topPosition = position.dy - (widget.position!.getHeight() / 2); | |||
There was a problem hiding this comment.
use final and handle the force unwrap
lib/src/tooltip_widget.dart
Outdated
| return (widget.screenSize!.height - position.dy) <= height; | ||
| var bottomPosition = position.dy + (widget.position!.getHeight() / 2); | ||
| var topPosition = position.dy - (widget.position!.getHeight() / 2); | ||
| return (widget.screenSize!.height - bottomPosition) <= height && |
There was a problem hiding this comment.
handle the force unwrap
faiyaz-shaikh
force-pushed
the
fix/tooltip_position_calculation
branch
2 times, most recently
from
c1ecbff to
dc8ec69
Compare
faiyaz-shaikh
force-pushed
the
fix/tooltip_position_calculation
branch
from
dc8ec69 to
233ebc0
Compare
vatsaltanna
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare widget position with bottom position instead of center position