Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #150 #179

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Fix bug #150 #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## [1.1.5] - December 2, 2021 [Unreleased]

- Fixed [#173](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/173) - showArrow not working
- Fixed [#150](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/150) - Add condition for determine state is active
- Fixed [#121](https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/issues/121) - SlideTransition widget in tooltip_widget.dart is constantly rebuildung even after the showcasing is supposed to have stopped

## [1.1.4] - November 26, 2021
Expand Down
14 changes: 8 additions & 6 deletions lib/src/layout_overlays.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,14 @@ class _OverlayBuilderState extends State<OverlayBuilder> {
}

void addToOverlay(OverlayEntry overlayEntry) async {
if (ShowCaseWidget.of(context)?.context != null &&
Overlay.of(ShowCaseWidget.of(context)!.context) != null) {
Overlay.of(ShowCaseWidget.of(context)!.context)!.insert(overlayEntry);
} else {
if (Overlay.of(context) != null) {
Overlay.of(context)!.insert(overlayEntry);
if (mounted) {
if (ShowCaseWidget.of(context)?.context != null &&
Overlay.of(ShowCaseWidget.of(context)!.context) != null) {
Overlay.of(ShowCaseWidget.of(context)!.context)!.insert(overlayEntry);
} else {
if (Overlay.of(context) != null) {
Overlay.of(context)!.insert(overlayEntry);
}
}
}
}
Expand Down