Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: overflow of long description #30

Closed
wants to merge 3 commits into from
Closed

FIX: overflow of long description #30

wants to merge 3 commits into from

Conversation

gitaaron
Copy link

@gitaaron gitaaron commented Nov 5, 2019 •
edited
Loading

Try to see if the content will overflow as hidden by the screen and if so place a limit on the tooltip width. If a limit is placed then the text seems to overflow to a new line.

I also added an option to add padding to the 'spotlight' as I personally think its a little more aesthetically pleasing.

@gitaaron gitaaron mentioned this pull request Nov 6, 2019
Closed
DevarshRanpara
DevarshRanpara suggested changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@DevarshRanpara DevarshRanpara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update,
But for certain cases your code produces some issues.(Run this PR in our example app and check the second screen UI of showcase animation).

Please resolve that issue and update PR.

@DevarshRanpara DevarshRanpara self-requested a review January 9, 2020 09:00
DevarshRanpara
DevarshRanpara suggested changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@DevarshRanpara DevarshRanpara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also resolve some conflicts for Master branch as well so that we can merge it easily.

@BirjuVachhani BirjuVachhani linked an issue Aug 15, 2020 that may be closed by this pull request
A long description overflows #27
Closed
@BirjuVachhani
Copy link
Contributor

@gitaaron Could you please check the review and resolve conflicts?

@BirjuVachhani
Copy link
Contributor

This seems to be fixed now.

@mhilalsh mhilalsh mentioned this pull request Mar 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgowthamanmca cgowthamanmca cgowthamanmca approved these changes

@caspereus caspereus caspereus approved these changes

@gowtham2809 gowtham2809 gowtham2809 approved these changes

@DevarshRanpara DevarshRanpara Awaiting requested review from DevarshRanpara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A long description overflows
6 participants
@gitaaron @BirjuVachhani @gowtham2809 @DevarshRanpara @caspereus @cgowthamanmca