Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad XML causing Except function doc comments to not work #112

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

sbeca
Copy link
Contributor

@sbeca sbeca commented Dec 3, 2023

Some incorrect XML was causing doc comments for the Except functions to not show up at all in IDEs and causing the following to output into doc XML files of downstream projects:

<!-- Badly formed XML comment ignored for member "M:PolyfillExtensions.Except``1(System.Collections.Generic.IEnumerable{``0},``0)" -->
<!-- Badly formed XML comment ignored for member "M:PolyfillExtensions.Except``1(System.Collections.Generic.IEnumerable{``0},``0[])" -->
<!-- Badly formed XML comment ignored for member "M:PolyfillExtensions.Except``1(System.Collections.Generic.IEnumerable{``0},``0,System.Collections.Generic.IEqualityComparer{``0})" -->
<!-- Badly formed XML comment ignored for member "M:PolyfillExtensions.Except``1(System.Collections.Generic.IEnumerable{``0},System.Collections.Generic.IEqualityComparer{``0},``0[])" -->

This PR fixes the XML so that it works correctly.

@SimonCropp SimonCropp added this to the 1.33.1 milestone Dec 3, 2023
@SimonCropp
Copy link
Owner

thanks

@SimonCropp SimonCropp merged commit a055ccb into SimonCropp:main Dec 3, 2023
1 check passed
@sbeca sbeca deleted the fix-except-doc-comments branch December 11, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants