dont add deregister to root session! (#186)

SimonDanisch · Oct 10, 2023 · c93ab58 · c93ab58
1 parent 631f44a
commit c93ab58
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/HTTPServer/helper.jl b/src/HTTPServer/helper.jl
@@ -23,5 +23,6 @@ function response_500(exception)
     ], body=body)
 end
 
-# TODO, can we n
-# Base.convert(::Type{HTTP.Response}, s::Exception) = response_500(s)
+# TODO, how to do this without pircay? THis happens inside HTTP, so we can't just use try & catch in our own code
+# WIthout this overload, we'll get a `cant convert Exception to HTTP.Response` error, without seeing the error.
+Base.convert(::Type{HTTP.Response}, s::Exception) = response_500(s)
diff --git a/src/serialization/caching.jl b/src/serialization/caching.jl
@@ -26,7 +26,8 @@ function register_observable!(session::Session, obs::Observable)
     # Only register one time
     if !haskey(root.session_objects, obs.id)
         updater = JSUpdateObservable(root, obs.id)
-        on(updater, root, obs)
+        deregister = on(updater, obs)
+        push!(session.deregister_callbacks, deregister)
     end
     return
 end