Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix export for AssetFolder #208

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix export for AssetFolder #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/js_source.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ function Base.show(io::IO, jsc::JSCode)
print_js_code(io, jsc, JSSourceContext())
end



function print_js_code(io::IO, @nospecialize(object), context::JSSourceContext)
id = get!(() -> string(hash(object)), context.objects, object)
print(io, "__lookup_interpolated('$(id)')")
Expand Down Expand Up @@ -107,6 +105,14 @@ end
function import_in_js(io::IO, session::Session, asset_server, asset::Asset)
ref = url(session, asset)
if asset.es6module
# Use absolute paths for es6modules, since they're not relative
# To the HTML file they're used in, but instead to the Bonito.js file
# TODO, teach Bonito about where the JS files are located,
# to make them relativ
# Should only be relevant for AssetFolder
if startswith(ref, ".")
ref = ref[2:end]
end
print(io, "import('$(ref)')")
else
print(io, "Bonito.fetch_binary($(ref))")
Expand Down Expand Up @@ -151,7 +157,6 @@ function inline_code(session::Session, asset_server, js::JSCode)
src = code
else
# reverse lookup and serialize elements

interpolated_objects = Dict(v => k for (k, v) in context.objects)
binary = BinaryAsset(session, interpolated_objects)
src = """
Expand Down
Loading