Return a message when a 429 http response is received (#115)

This adds a case for handling 429 responses from Simperium, which has an empty response body, and adds a response text which can then be used to handle this error specifically.
Simperium · Oct 1, 2021 · bd7ba06 · bd7ba06
1 parent cc5885d
commit bd7ba06
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.1.4
+
+- Adds a message response when receiving a 429 HTTP error [#115](https://github.com/simperium/node-simperium/pull/115)
+
 ## 1.1.3
 
 - Fixes a sync issue by reverting the changes from PR #101 [#114](https://github.com/simperium/node-simperium/pull/114)

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "simperium",
-  "version": "1.1.3",
+  "version": "1.1.4",
   "description": "A simperium client for node.js",
   "main": "./lib/simperium/index.js",
   "browser": {

diff --git a/src/simperium/http-request.browser.js b/src/simperium/http-request.browser.js
@@ -10,7 +10,12 @@ export default function(
 		xhr.open( 'POST', url );
 		xhr.setRequestHeader( 'X-Simperium-API-Key', apiKey );
 
-		xhr.onload = () => resolve( xhr.responseText );
+		xhr.onload = () => {
+			if ( xhr.status === 429 && xhr.responseText === '' ) {
+				return resolve('too many requests');
+			}
+			resolve(xhr.responseText);
+		};
 		xhr.onerror = () => reject();
 
 		xhr.send( body );