Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add github workflow/action and remove travis ci #6500

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

live627
Copy link
Contributor

@live627 live627 commented Feb 6, 2021

Depends on SimpleMachines/BuildTools#12

JavaScript linting can be left for the future since our codebase isn't up to snuff yet, with different styles.

This will serve as the first phase of CI.

The version checking script will become problematic as we go to GA/patch only, because then not all files get version updates. See2.0.18.

@live627 live627 added the Meta Repository tools/code reorganization label Feb 6, 2021
@pr-triage pr-triage bot added the PR: draft label Feb 6, 2021
@m4z
Copy link

m4z commented Feb 6, 2021

Since #6501 is just ditching PHP 5.4, what's the plan re legacy-php.yml? Remove the test once it begins to fail, or still fix 5.4 errors despite not officially supporting it? Or can the check be made "optional"?

@live627
Copy link
Contributor Author

live627 commented Feb 6, 2021 via email

@live627
Copy link
Contributor Author

live627 commented Feb 8, 2021

Actually, I got rid of it because of php 7 code. What happened is that overtrue/phplint uses Symfony components which use php 7 code. I'm not ggoing to put in the effort to add something else. Someone else can if they wish. I'm not going to bother with php 5 for cd any longer.

@live627 live627 marked this pull request as ready for review February 8, 2021 09:10
@live627 live627 merged commit 2023d5f into SimpleMachines:release-2.1 Feb 9, 2021
@pr-triage pr-triage bot added the PR: merged label Feb 9, 2021
@live627 live627 deleted the meta branch February 9, 2021 02:09
jdarwood007 added a commit to jdarwood007/SMF that referenced this pull request Feb 26, 2021
…d as a sub module. Remove it.

Fixes a issue introduced by SimpleMachines#6500
live627 pushed a commit that referenced this pull request Feb 27, 2021
…d as a sub module. Remove it. (#6540)

Fixes a issue introduced by #6500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta Repository tools/code reorganization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants