Moving several important warnings to templates #8422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live627
commented
Jan 28, 2025
| $position = array_search('body', Utils::$context['template_layers']); | ||
|
|
||
| if ($position !== false) { | ||
| array_splice(Utils::$context['template_layers'], $position + 1, 0, ['maint_warning']); | ||
| array_splice(Utils::$context['template_layers'], $position + 1, 0, $layers); |
There was a problem hiding this comment.
Would this code be better suited for Theme:::loadTemplatesAndLangFiles()?
There was a problem hiding this comment.
It would fit better there in an abstract, conceptual sense, yes. But then it would be called during Theme::load(), which would be problematic for a number of reasons.
live627
force-pushed
the
securityFiles
branch
from
be33569 to
c3ff515
Compare
Sesquipedalian
requested changes
Jan 29, 2025
| $position = array_search('body', Utils::$context['template_layers']); | ||
|
|
||
| if ($position !== false) { | ||
| array_splice(Utils::$context['template_layers'], $position + 1, 0, ['maint_warning']); | ||
| array_splice(Utils::$context['template_layers'], $position + 1, 0, $layers); |
There was a problem hiding this comment.
It would fit better there in an abstract, conceptual sense, yes. But then it would be called during Theme::load(), which would be problematic for a number of reasons.
Co-authored-by: Jon Stovell <jonstovell@gmail.com>
live627
commented
Jan 29, 2025
Sesquipedalian
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Templates for Warnings (
Themes/default/index.template.php):template_maint_warning_*).template_security_warning_above/below).template_banned_warning_above/below).ins about potential security risks.