Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.2.3 #29

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Release 0.2.3 #29

merged 1 commit into from
Oct 20, 2024

Conversation

gventuri
Copy link
Contributor

@gventuri gventuri commented Oct 20, 2024

  • fix: broken ui issues in safari

  • fix[pdfHighlight]: build and pdf highlight issues resolved

  • fix: build issues on github

  • fix: build issues

  • fix: build issues

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced error handling for process steps, including specific management for credit limit exceptions.
    • Improved logic for determining process completion status.
  • Improvements

    • Conditional logic added for setting file URLs in the ChatReferenceDrawer component.
    • Streamlined markdown rendering in ChatBubble and MessageWithReferences components by removing the GFM plugin.
    • Dynamic highlight positioning in the HighlightPdfViewer component for better display across devices.
  • Chores

    • Added a polyfill for Promise.withResolvers in the HighlightPdfViewer for compatibility.

* fix: broken ui issues in safari

* fix[pdfHighlight]: build and pdf highlight issues resolved

* fix: build issues on github

* fix: build issues

* fix: build issues
Copy link
Contributor

coderabbitai bot commented Oct 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications across several files, primarily focusing on the backend processing logic in process_queue.py, enhancements to error handling, and adjustments to frontend components. The backend now includes failed process steps in status handling, improves error management, and refines completion logic. On the frontend, components like ChatBubble, MessageWithReferences, and ChatReferenceDrawer have updated logic for rendering and handling references, while HighlightPdfViewer introduces a polyfill for compatibility and improves highlight rendering based on device pixel ratio.

Changes

File Path Change Summary
backend/app/processing/process_queue.py - Updated process step status handling to include FAILED steps.
- Enhanced error handling for CreditLimitExceededException.
- Revised completion logic to mark processes as COMPLETED only if no failed documents exist.
- Clarified criteria for parallel processing of tasks.
- Improved logging for processing flow.
- Structured invocation of update_process_step_status.
frontend/next.config.mjs - Added swcMinify: false to nextConfig for future tracking.
frontend/src/components/ChatReferenceDrawer.tsx - Updated logic to conditionally set file_url based on isOpen state.
- Retained error logging for missing filename only when isOpen is true.
frontend/src/components/ui/ChatBubble.tsx - Removed remarkGfm plugin from ReactMarkdown.
- Adjusted props to include references for conditional rendering.
frontend/src/components/ui/MessageWithReferences.tsx - Removed remarkGfm plugin from ReactMarkdown, maintaining overall functionality.
frontend/src/ee/components/HighlightPdfViewer.tsx - Introduced polyfill for Promise.withResolvers for compatibility.
- Updated worker source URL for pdfjs.
- Modified highlight position calculations based on window.devicePixelRatio.

Possibly related PRs

🐇 In the code we hop and play,
Process steps in a new ballet.
Errors caught, and logs in sight,
Chat bubbles bloom, oh what delight!
With highlights bright on screens we see,
A joyful code, as it should be! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gventuri gventuri merged commit e09e85c into main Oct 20, 2024
4 of 5 checks passed
@gventuri gventuri deleted the release/v0.2.3 branch October 20, 2024 09:08
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.09%. Comparing base (b82c6e3) to head (f16810c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/app/processing/process_queue.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   54.09%   54.09%           
=======================================
  Files          37       37           
  Lines        1806     1806           
=======================================
  Hits          977      977           
  Misses        829      829           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants