tests: fix failing tests for win platform (#347) #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add compatibility for win platforms in `test_run_with_privacy_enforcement()` * add compatibility for win platforms in `test_run_without_privacy_enforcement()`
|
@nautics889 thanks a lot for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is for contributors who are developing on Windows platform. Some tests were failing because of
\r\ninstead of\n, the problem described in issue #347Add checking for platform in some test cases and replacing
\r\nwith\nif the platform's name starts with"win".add compatibility for win platforms in
test_run_with_privacy_enforcement()add compatibility for win platforms in
test_run_without_privacy_enforcement()p. s. i guess it would be great to move some fixtures in files (too much hardcoded multiline texts in tests modules) or generating them via Faker. I'd be glad to hear an outside perspective about that.