Skip to content

Commit

Permalink
Remove lines allowing clippy cognitive complexity checks.
Browse files Browse the repository at this point in the history
Since these allow lines were added, this clippy lint has been downgraded
to a nursery check via
rust-lang/rust-clippy#5428

Since we don't have allows for other nursery lints, I suggest we remove
these ones.
  • Loading branch information
SingingTree committed Jan 21, 2021
1 parent 9fb77e6 commit 9b07771
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions mp4parse/tests/public.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ static AVIF_CORRUPT_IMAGES: &str = "tests/corrupt";

// Adapted from https://github.com/GuillaumeGomez/audio-video-metadata/blob/9dff40f565af71d5502e03a2e78ae63df95cfd40/src/metadata.rs#L53
#[test]
#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this
fn public_api() {
let mut fd = File::open(MINI_MP4).expect("Unknown file");
let mut buf = Vec::new();
Expand Down Expand Up @@ -161,7 +160,6 @@ fn public_api() {
}

#[test]
#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this
fn public_metadata() {
let mut fd = File::open(MINI_MP4_WITH_METADATA).expect("Unknown file");
let mut buf = Vec::new();
Expand Down Expand Up @@ -228,7 +226,6 @@ fn public_metadata() {
}

#[test]
#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this
fn public_metadata_gnre() {
let mut fd = File::open(MINI_MP4_WITH_METADATA_STD_GENRE).expect("Unknown file");
let mut buf = Vec::new();
Expand Down Expand Up @@ -486,7 +483,6 @@ fn public_audio_cbcs() {
}

#[test]
#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this
fn public_video_cbcs() {
let system_id = vec![
0x10, 0x77, 0xef, 0xec, 0xc0, 0xb2, 0x4d, 0x02, 0xac, 0xe3, 0x3c, 0x1e, 0x52, 0xe2, 0xfb,
Expand Down Expand Up @@ -567,7 +563,6 @@ fn public_video_cbcs() {
}

#[test]
#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this
fn public_video_av1() {
let mut fd = File::open(VIDEO_AV1_MP4).expect("Unknown file");
let mut buf = Vec::new();
Expand Down
1 change: 0 additions & 1 deletion mp4parse_capi/tests/test_encryption.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ extern "C" fn buf_read(buf: *mut u8, size: usize, userdata: *mut std::os::raw::c
}

#[test]
#[allow(clippy::cognitive_complexity)] // TODO: Consider simplifying this
fn parse_cenc() {
let mut file = std::fs::File::open("tests/short-cenc.mp4").expect("Unknown file");
let io = Mp4parseIo {
Expand Down

0 comments on commit 9b07771

Please sign in to comment.