Consider embedded input source map in file coverage #87
Conversation
Current coverage is 97.44% (diff: 75.00%)@@ master #87 diff @@
==========================================
Files 13 13
Lines 428 430 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 418 419 +1
- Misses 10 11 +1
Partials 0 0
|
|
I will apply the requested changes as soon as istanbuljs-archived-repos/istanbul-lib-instrument#23 is landed |
MichaReiser
force-pushed
the
consider-sourcemap-from-file-coverage
branch
from
f50c1f0
to
96911f6
Compare
|
Rebased and spaces converted to tab... Feature is going to land in istanbul this week! |
|
This is now an officialy supported feature of istanbul.... |
|
@dylans Any chance of re-reviewing and merging this? This looks to be the final piece in the long saga of getting working code coverage for transpiled code. |
|
First another rebase is needed. However, I'm not going to rebase again if there is no chance that the change is going to be merged any time soon. Because I don't want to spend meaningless hours rewriting / rebasing the code without any chance that the change is accepted.... even if the feature is urgently needed by all using a transpiled language |
|
@MichaReiser if you do have anytime to rebase this, I will land it right after you do so. Thanks for your work! |
MichaReiser
force-pushed
the
consider-sourcemap-from-file-coverage
branch
from
96911f6
to
a990033
Compare
When locating the source map, use the source map included in the file coverage whenever possible. Closes SitePen#2
| @@ -91,7 +93,7 @@ class CoverageTransformer { | |||
| } | |||
| } | |||
|
|
|||
| if (!match || !rawSourceMap) { | |||
| if (!rawSourceMap) { | |||
There was a problem hiding this comment.
I'm not 100% sure if this is right this way... But i think this check is sufficient since we only need to have a source map (we dont care about a match... just throw an error if we could not find the source map)
There was a problem hiding this comment.
You're right we don't need that check
|
@jdonaghue The change is rebased.... Not sure how to add tests though... |
|
This looks good @MichaReiser thanks for your work! Landing this now. |
|
Yeah finally... A long story finally ends :) When can we expect a release to npm? |
|
Uraaaaaaaaaaaaaa, I had the exact problem when sourceMappingUrl was not generated but inputSourceMap was included in coverage instead, fixed the remap.js locally. So happy that this is already done by someone else. |
When locating the source map, use the source map included in the file coverage whenever possible. Closes #2 but requires istanbuljs-archived-repos/istanbul-lib-instrument#23