Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sitecore Experience Platform Container Deployment 10.4.0.010422.1755 #149

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

sc-eugeniabelinskaya
Copy link
Collaborator

Release of ltsc2022 support for Sitecore Experience Platform 10.4.0 rev. 010422

@sc-eugeniabelinskaya sc-eugeniabelinskaya requested a review from a team as a code owner April 22, 2024 05:55
Copy link
Contributor

@sc-piotrpiatek sc-piotrpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are adequate and in sync

Copy link

@peternazarov peternazarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider updating traefik: to the latest v2 image version so that all containers can run in the same isolation, including "process" isolation.

CD_HOST=xm1cd.localhost
CM_HOST=xm1cm.localhost
ID_HOST=xm1id.localhost
TRAEFIK_IMAGE=traefik:v2.9.8-windowsservercore-1809

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider using the latest version of v2 so that all containers can run in "process" isolation in local dev. For example: traefik:2.11.2-windowsservercore-ltsc2022

I have tested traefik:2.11.0-windowsservercore-ltsc2022 already with 10.2 and 10.3 with "process" isolation on Windows 11. It just works, just change the image tag and isolation - no other changes are needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peternazarov latest v3 version of traefik is being tested with all SXP versions at the moment, we'll soon update the public configuration accordingly. Expect the update. :)

image: ${SITECORE_DOCKER_REGISTRY}redis:3.2.100-${EXTERNAL_IMAGE_TAG_SUFFIX}
mssql:
isolation: ${ISOLATION}
image: ${SITECORE_DOCKER_REGISTRY}nonproduction/mssql-developer:2022-${EXTERNAL_IMAGE_TAG_SUFFIX}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for providing the SQL 2022 image!

CM_HOST=xm1cm.localhost
ID_HOST=xm1id.localhost
TRAEFIK_IMAGE=traefik:v2.9.8-windowsservercore-1809
TRAEFIK_ISOLATION=hyperv

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for this anymore when the latest version of v2 traefik container is used.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peternazarov thank you for the comments! Passed on to the dev team to be addressed shortly.

@sc-eugeniabelinskaya sc-eugeniabelinskaya merged commit 5aa8762 into master Apr 29, 2024
@sc-eugeniabelinskaya sc-eugeniabelinskaya deleted the sxp/10.4.0.010422.1755 branch April 29, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants