SIA-R10: Accept webauthn token
#1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule logic was also been cleaned up a bit and a few bugs where discovered and fixed. The bugs where: * Modifiers like `home` followed by nothing was passing * Valid tokens followed by invalid tokens was passing
rcj-siteimprove
added
the
major
Jym77
requested changes
Feb 8, 2023
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
This is just a first crude attempt and should probably be reworked, but it seems to work.
…e/alfa into sia-r10-accept-webauthn-token
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rcj-siteimprove
commented
Feb 13, 2023
rcj-siteimprove
commented
Feb 13, 2023
Jym77
changed the title
webauthn token in sia-r10webauthn token
Jym77
added
patch
Jym77
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1332
The rule has been updated to accept autocomplete attribute token
webauthn.In addition a few bugs where discovered and fixed. The bugs where:
homefollowed by nothing were incorrectly passing