R113 follow up #1592
Merged
R113 follow up #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1061bbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 78 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rcj-siteimprove
added
the
minor
Jym77
requested changes
Apr 2, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
!pr extract |
|
!pr extract |
|
@Jym77 I'm not sure I'm happy about the way I collect the neighbors by passing in and pushing to an array, but I couldn't think of any much better solution due to how the expectation function works. Please advise if you see a better way 😄 |
Jym77
requested changes
Apr 5, 2024
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
|
!pr extract |
Jym77
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #1589
We send more granular information about how the rule succeeded in the extended diagnostics and the spacing computation should now be correctly implemented.
The spacing still has a quadratic runtime, but I'm working on finding a solution using some kind of search tree. I might add it to this PR or in another follow up.
The image shows how the distance to the corners are calculated:
