Add memoization to Cache
#1720
Open
Add memoization to Cache
#1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 83540d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 77 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Jym77
commented
Nov 25, 2024
Comment on lines
61
to
65
| const hasHiddenAncestors = Cache.memoize< | ||
| unknown, | ||
| [Device, Context], | ||
| Predicate<Node> | ||
| >(_hasHiddenAncestors); |
There was a problem hiding this comment.
I'm not sure why TS needs some skaffolding here, but not in the simple cases in the tests 🤷
Jym77
commented
Nov 25, 2024
| const cache = Cache.empty<Device, Cache<Context, Cache<Node, boolean>>>(); | ||
|
|
||
| function hasHiddenAncestors( | ||
| function _hasHiddenAncestors( |
There was a problem hiding this comment.
This is just a demo of using the new decorator, not directly related to the changes.
| ), | ||
| // Or its parent is programmatically hidden | ||
| (node: Node) => | ||
| node.parent(Node.fullTree).some(_hasHiddenAncestors(device, context)), |
There was a problem hiding this comment.
Question: Is it on purpose the call is to _hasHiddenAncestors and not hasHiddenAncestors? I can't tell if it makes a difference, but in the original code, in the recursion the cache would be used, but now it's going to recurse without the cache, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.