Speedup table building #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jym77
added
the
internal
Jym77
commented
Jun 24, 2020
| /** | ||
| * Update cells/downward growing cells, and resync slots with all (updated) cells | ||
| */ | ||
| public updateCells({ |
There was a problem hiding this comment.
updateCells, addCells and _updateSlots are duplicated in row, row group and table.
Given that they are fairly complex (and I did fix a bunch of bugs in it), I'd really like to refactor this, but I'm not sure about the best way to do… parent abstract class? other?
|
Also optimizing the table model errors checks. |
kasperisager
approved these changes
Jun 25, 2020
kasperisager
added a commit
that referenced
this pull request
Jul 1, 2020
* master: (21 commits) Rework the way DOM parent pointers are handled (#283) Create a GitHub release as part of release workflow Backtrack on shortcut links v0.3.0 Prepare release Update changelog Update changelog `RoleOptions#allowPresentational` must be optional Update SIA R67 (#272) Update lockfile Correctly resolve important and overridden CSS properties (#282) Introduce HyperScript-like DSL for constructing DOM (#281) Use dynamic import rather than `require()` for loading formatters (#278) Add `Future#get()` and accept thunked promises in `Future.from()` (#279) Fix default argument type parameter of several types Speedup table building (#276) Add initial support for `background` shorthand property (#277) Output stack in CLI errors if available Chesterton's fence strikes again! Correctly pull `.message` from expectations ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should significantly speed up table building by registering which row/column contains data cell and thus avoid going through all cells when computing scope.
More speedup can be achieved on the internal headers scanning. Looking into it.
Also improving code for
updatefunction with cleaner default parameters initialisation.