Implement style resolution for stateful pseudo classes #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperisager
added
the
major
Jym77
requested changes
Oct 9, 2020
Jym77
approved these changes
Oct 9, 2020
kasperisager
added a commit
that referenced
this pull request
Oct 19, 2020
* master: (190 commits) Bump jest from 26.5.2 to 26.5.3 (#453) Bump @types/jquery from 3.5.2 to 3.5.3 (#455) Bump webdriverio from 6.6.2 to 6.6.6 (#458) Bump @types/node from 14.11.7 to 14.11.10 (#460) Bump @types/react from 16.9.51 to 16.9.53 (#461) Bump mdn-browser-compat-data from 1.0.40 to 1.1.0 (#451) Bump webdriverio from 6.6.0 to 6.6.2 (#449) Implement style resolution for stateful pseudo classes (#448) Bump @types/node from 14.11.5 to 14.11.7 (#450) Bump @angular/core from 10.1.4 to 10.1.5 (#446) Fix several `Element#tabIndex()` cases (#445) Implement presentational role inheritance (#443) Improve handling of cyclic `aria-owns` references (#442) Bump jest from 26.5.0 to 26.5.2 (#441) Bump webdriverio from 6.5.2 to 6.6.0 (#440) Implement traversal API for `Graph` (#426) Exclude from the accessibility tree text nodes of parent elements with `visibility: hidden` (#437) Implement step 2H of the name computation (#430) Bump @types/node from 14.11.2 to 14.11.5 (#436) Bump @types/node from 14.11.2 to 14.11.4 (#431) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements style resolution for the following stateful pseudo classes:
:hover:active:focus:focus-within:focus-visible:link:visitedA new class,
Context, has been introduced to model context-dependant information during selector matching, such as which element is currently in focus, which elements have been visited, and so on. This class is heavily inspired by Servo (components/selectors/context.rs) and works by modelling state as bit flags associated with elements. As an example, this means that it's up to the caller, notSelector#matches(), to decide if a given element links to a resource that has been visited;Selector#matches()simply checks the associated state, not the actual URL of the element being matched against.This pull request also introduces changes to the way cascade is managed to allow efficiently re-computing cascade for elements when context changes. The
Cascadeclass is now no longer immutable, but instead incrementally builds up a rule tree and caches entries for elements keyed on context. A "baseline" cascade is performed at construction time and computes cascade for all elements in a document with an empty context to benefit from ancestor filtering during selector matching. From then, matching declarations for individual elements can be queried with an optional context that defaults to an empty context. Whenever a non-yet-seen context is passed for an element, the rule tree is extended with matching declarations for the element and associated context.Closes #447.