Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shared infrastructure #169

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Conversation

brianpopow
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This Pull request updates the shared infrastructure submodule and fixes the warnings.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #169 (6f91008) into master (7ffae70) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   70.03%   69.98%   -0.05%     
==========================================
  Files          89       89              
  Lines        5209     5201       -8     
  Branches     1062     1062              
==========================================
- Hits         3648     3640       -8     
  Misses       1347     1347              
  Partials      214      214              
Flag Coverage Δ
unittests 69.98% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ing/Common/Extensions/GraphicsOptionsExtensions.cs 100.00% <ø> (ø)
src/ImageSharp.Drawing/Processing/Brushes.cs 100.00% <ø> (ø)
src/ImageSharp.Drawing/Processing/ColorStop.cs 100.00% <ø> (ø)
...rc/ImageSharp.Drawing/Processing/DrawingOptions.cs 89.65% <ø> (ø)
src/ImageSharp.Drawing/Processing/GradientBrush.cs 85.96% <ø> (ø)
...ageSharp.Drawing/Processing/LinearGradientBrush.cs 100.00% <ø> (ø)
src/ImageSharp.Drawing/Processing/PatternBrush.cs 83.33% <ø> (ø)
...ageSharp.Drawing/Processing/RadialGradientBrush.cs 100.00% <ø> (ø)
src/ImageSharp.Drawing/Processing/RecolorBrush.cs 96.55% <ø> (ø)
src/ImageSharp.Drawing/Processing/ShapeOptions.cs 100.00% <ø> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffae70...6f91008. Read the comment docs.

@brianpopow brianpopow requested a review from a team October 8, 2021 15:20
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 👍

@JimBobSquarePants JimBobSquarePants merged commit eb510f3 into master Oct 10, 2021
@JimBobSquarePants JimBobSquarePants deleted the bp/updatesharedinfra branch October 10, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants