Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for PatterBrush issue 241 #274

Merged
merged 3 commits into from
May 5, 2023
Merged

Add tests for PatterBrush issue 241 #274

merged 3 commits into from
May 5, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #241
This must have been fixed in the rewrite of the brushes. I've added the test from the issue and removed some unused fields from the brush.

@JimBobSquarePants JimBobSquarePants added the bug Something isn't working label May 5, 2023
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0 milestone May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #274 (746f10f) into main (83747f4) will decrease coverage by 1%.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #274   +/-   ##
===================================
- Coverage    78%    78%   -1%     
===================================
  Files        97     97           
  Lines      5067   5065    -2     
  Branches    932    932           
===================================
- Hits       3985   3983    -2     
  Misses      898    898           
  Partials    184    184           
Flag Coverage Δ
unittests 78% <ø> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp.Drawing/Processing/PatternBrush.cs 76% <ø> (-1%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants merged commit f72bd7a into main May 5, 2023
@JimBobSquarePants JimBobSquarePants deleted the js/fix-241 branch May 5, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drawText with PatternBrush ThrowArgumentOutOfRangeException
3 participants