Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipper upstream fixes #282

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Clipper upstream fixes #282

merged 4 commits into from
Aug 14, 2023

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Aug 14, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Updates the polygon clipping code to include all relevant upstream fixes.
Also includes some minor cleanup.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #282 (85ec501) into main (072ecd7) will increase coverage by 1%.
The diff coverage is 42%.

@@         Coverage Diff         @@
##           main   #282   +/-   ##
===================================
+ Coverage    79%    80%   +1%     
===================================
  Files        97     97           
  Lines      5088   5020   -68     
  Branches    947    919   -28     
===================================
+ Hits       4021   4025    +4     
+ Misses      868    796   -72     
  Partials    199    199           
Flag Coverage Δ
unittests 80% <42%> (+1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ImageSharp.Drawing/Processing/PathGradientBrush.cs 82% <ø> (-1%) ⬇️
...mageSharp.Drawing/Shapes/PolygonClipper/BoundsF.cs 0% <0%> (ø)
...harp.Drawing/Shapes/PolygonClipper/ClipperUtils.cs 39% <37%> (-3%) ⬇️
...rp.Drawing/Shapes/PolygonClipper/PolygonClipper.cs 68% <75%> (+3%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants merged commit b059f31 into main Aug 14, 2023
@JimBobSquarePants JimBobSquarePants deleted the js/clipper-upstream-fixes branch August 14, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants