Ensure the negatively offset shapes are correctly offset the ImageBrush Texture during rendering. #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tocsoft
force-pushed
the
sw/image-brush-offsets
branch
from
0fe678a
to
25fab5c
Compare
tocsoft
force-pushed
the
sw/image-brush-offsets
branch
from
25fab5c
to
e7f368f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
===================================
Coverage 80% 80%
===================================
Files 97 97
Lines 4946 4960 +14
Branches 884 886 +2
===================================
+ Hits 3997 4011 +14
Misses 754 754
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tocsoft
force-pushed
the
sw/image-brush-offsets
branch
from
9c29271
to
9269ea9
Compare
| /// The region of interest. | ||
| /// This overrides any region used to initialize the brush applicator. | ||
| /// </param> | ||
| internal ImageBrush(Image image, RectangleF region) |
There was a problem hiding this comment.
This makes the constructor internal again. Was that intentional?
There was a problem hiding this comment.
nope, I had failed to update my working branch when I started the PR. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This fixes up the fill with brush pipelines to ensure that the push gets the correct region its supposed to be filling, even if they are negatively offset.
It also exposes a new ImageBrush constructor overload to allow manually offsetting the texture independent to the drawn location. This is needed by the
Clipprocessor as the texture its working with doesn't always line-up nicely when negative offsets are applied.resolves #308