Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ExifTag TimeZoneOffset to Signed Short #2541

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Change ExifTag TimeZoneOffset to Signed Short #2541

merged 2 commits into from
Oct 4, 2023

Conversation

Cheesebaron
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #2437

As per the linked issue. TimeZoneOffset is a signed short array. However, currently in ImageSharp it is treated as a unsigned short array.

Changing the type to match the spec.

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

dlemstra
dlemstra reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@dlemstra dlemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping us with this PR! Looks good to me.

@Cheesebaron
Copy link
Contributor Author

Happy to help. Let me know if anything needs tweaking here.

JimBobSquarePants
JimBobSquarePants approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!!

@JimBobSquarePants JimBobSquarePants merged commit d378306 into SixLabors:main Oct 4, 2023
8 checks passed
@Cheesebaron Cheesebaron deleted the bugfix/2437-timezoneoffset-exif-type branch October 5, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlemstra dlemstra dlemstra left review comments

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExifTag.TimeZoneOffset is defined as uint[], but the TIFF spec defines it as signed short
4 participants
@Cheesebaron @CLAassistant @JimBobSquarePants @dlemstra