Tiff decoding robustness improvements #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBobSquarePants
requested review from
tocsoft,
antonfirsov,
dlemstra and
brianpopow
antonfirsov
approved these changes
Oct 14, 2023
| { | ||
| return totalBytesRead; | ||
| } | ||
|
|
||
| totalBytesRead += bytesRead; | ||
| } | ||
|
|
||
| return totalBytesRead; | ||
| } |
There was a problem hiding this comment.
Since we are already touching this class: we should check the return value of this.innerStream.Read in InitializeInflateStream when it's skipping 4 bytes.
There was a problem hiding this comment.
Pushed the change together with another check.
There was a problem hiding this comment.
Good changes. Thanks!
antonfirsov
reviewed
Oct 14, 2023
antonfirsov
added a commit
that referenced
this pull request
Oct 15, 2023
JimBobSquarePants
pushed a commit
that referenced
this pull request
Oct 16, 2023
antonfirsov
added a commit
that referenced
this pull request
Oct 16, 2023
antonfirsov
added a commit
that referenced
this pull request
Oct 16, 2023
(accidental push to unprotected branch)
antonfirsov
added a commit
that referenced
this pull request
Oct 16, 2023
JimBobSquarePants
pushed a commit
that referenced
this pull request
Oct 16, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Adds additional checks to the decoder infrastructure to enable us to better handle corrupt files.
Some light formatting cleanup also.