Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DrawImage processor more robust to bad input. #2673

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Feb 23, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Moving the foreground image intersect to before the sanitation check ensures invalid arguments are not processed.

Fixes #2663 will duplicate for main following this fix.

@JimBobSquarePants JimBobSquarePants merged commit a11c5e7 into release/3.1.x Feb 24, 2024
15 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/fix-2663 branch February 24, 2024 05:15
JimBobSquarePants added a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants