Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear Pixel Buffers on Decode. #2716

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Clear Pixel Buffers on Decode. #2716

merged 1 commit into from
Apr 10, 2024

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Ensure that all decoders clear the pixel buffer on allocation.

@JimBobSquarePants JimBobSquarePants mentioned this pull request Apr 6, 2024
Merged
4 tasks
antonfirsov
antonfirsov approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a 0.5%-1% perf regression in Jpeg from this, which is fine.

@antonfirsov antonfirsov merged commit da5f09a into release/3.1.x Apr 10, 2024
15 checks passed
@antonfirsov antonfirsov deleted the js/clear-buffers branch April 10, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonfirsov antonfirsov antonfirsov approved these changes

@tocsoft tocsoft Awaiting requested review from tocsoft

@dlemstra dlemstra Awaiting requested review from dlemstra

@brianpopow brianpopow Awaiting requested review from brianpopow

Assignees
No one assigned
Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimBobSquarePants @antonfirsov