Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2759 to 2.1.x #2770

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Conversation

antonfirsov
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Implemented it by a full port of 3.1.x Gif Decoder, so it contains improvements and behavioral changes made since then. It also decodes some stuff 2.1 API doesn't expose.

I didn't fully understand what was the JPEG change about, but the 2.1 decoder detects it as an invalid image. Added the test as a skipped test.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

I think incorporating the full decoder was probably wise here. There were likely other critical issues missed over time that should be included.

The jpeg issue in v3.1.x was that the chrominance quality was being determined as zero. This led to the encoder trying to divide by that value. I'm fine with decoder throwing an exception here.

@JimBobSquarePants JimBobSquarePants merged commit 9816ca4 into release/2.1.x Jul 15, 2024
14 checks passed
@JimBobSquarePants JimBobSquarePants deleted the af/backport-2759-2.1.x branch July 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants