Beta 1 #299
Merged
Beta 1 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (Optimizing PNG-s with external tools from now.)
# Conflicts: # tests/Images/External
# Conflicts: # tests/ImageSharp.Tests/TestFile.cs
Update namespaces & package names
Also fix Oilpainting test
|
woops, fixing the build now |
antonfirsov
reviewed
Sep 12, 2017
| @@ -138,7 +138,7 @@ public static void Save<TPixel>(this Image<TPixel> source, Stream stream, IImage | |||
| /// <param name="source">The source image</param> | |||
| /// <param name="buffer">The buffer to save the raw pixel data to.</param> | |||
| /// <exception cref="System.ArgumentNullException">Thrown if the stream is null.</exception> | |||
| public static void SavePixelData<TPixel>(this Image<TPixel> source, Span<byte> buffer) | |||
| internal static void SavePixelData<TPixel>(this Image<TPixel> source, byte[] buffer) | |||
There was a problem hiding this comment.
We could probably expose a SavePixelData(byte[] buffer, int offset) and a SavePixelData(byte[] buffer) variant publicly.
There was a problem hiding this comment.
i've made it public in the Image-Frame branch
API Image frames refactor
|
Made some further decoder optimazation by optimizing |
…ecause BufferArea ctr now uses DebugGuard
antonfirsov
added a commit
that referenced
this pull request
Sep 16, 2017
antonfirsov
added a commit
that referenced
this pull request
Sep 16, 2017
antonfirsov
pushed a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR collects the following PR's together so we can release our first beta. I really want to get this out so I took the bull by the horns and did some of the manual merging required to put it all together.
Which means we have the new API, namespace, and jpeg decoder included in the codebase.
The project builds but I couldn't get the reference image tests running locally for the new
qa-labstuff.@antonfirsov How does the external image references thing work?
@tocsoft I seem to have broken AppVeyor, no idea how.
Please have a good look through this and make sure all is well. I'll get cracking on a blog post asap unless someone volunteers.