Disposing data chunk instead of explicit returning it to ArrayPool in PngDecoderCore.Identify #534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The new
Image.Identify
API was introduced in #292. In #475 memory management was significantly improved, but there is still a case forpng
format whenArrayPool
is used directly when callingImage.Identify
, not withIManagedByteBuffer
API.This leads to the issue when
ArgumentException
is throwing inArrayPool.Return
method with this message:This PR fixes this problem.