remove SavePixelData()
apis in favour of GetPixelSpan()
#628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
removed all the
SavePixelData()
apis (as they can cause confusion people see a save method with a byte array and assume its an encoded image they can pass into something else and its not it was just a raw dump of our internal buffer).To get a copy of the image buffer now you should instead add the
using SixLabors.ImageSharp.Advanced;
which will expose our Span apis which can be used to access the raw pixel buffer for any inter-op scenarios.resolves #623